GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix PCI ACPI _OSC methods 

Fix the IASL build warnings:
Object is not referenced (Name [CDW2] is within a method [_OSC])
Object is not referenced (Name [CDW3] is within a method [_OSC])

Remove the not referenced objects. They are not needed.

BUG=b:112476331
TEST=IASL doesn't give the warning.

Change-Id: I5b38d4de3f9875c5b013a49eb5146bf5916b96a6
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: https://review.coreboot.org/28121
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Marc Jones 2018-08-15 22:17:45 -06:00 committed by Martin Roth
parent 4988fe2986
commit 1faa11ed39
5 changed files with 5 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/northbridge/intel/i945/acpi/i945.asl
View File

@ -20,17 +20,13 @@
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method (_OSC, 4) Method (_OSC, 4)
{ {
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3, 0, CDW1)
CreateDWordField(Arg3, 4, CDW2)
CreateDWordField(Arg3, 8, CDW3)
/* Check for proper PCI/PCIe UUID */ /* Check for proper PCI/PCIe UUID */
If (LEqual(Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) If (LEqual(Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return(Arg3) Return(Arg3)
} Else { } Else {
CreateDWordField(Arg3, 0, CDW1)
Or(CDW1, 4, CDW1) // Unrecognized UUID, so set bit 2 to 1 Or(CDW1, 4, CDW1) // Unrecognized UUID, so set bit 2 to 1
Return(Arg3) Return(Arg3)
} }

6
src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl
View File

@ -22,17 +22,13 @@ External(\_SB.ALIB, MethodObj)
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method(_OSC,4)
{ {
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3,0,CDW1)
CreateDWordField(Arg3,4,CDW2)
CreateDWordField(Arg3,8,CDW3)
/* Check for proper PCI/PCIe UUID */ /* Check for proper PCI/PCIe UUID */
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} Else { } Else {
CreateDWordField(Arg3,0,CDW1)
Or(CDW1,4,CDW1) // Unrecognized UUID Or(CDW1,4,CDW1) // Unrecognized UUID
Return(Arg3) Return(Arg3)
} }

6
src/southbridge/amd/agesa/hudson/acpi/fch.asl
View File

@ -20,17 +20,13 @@
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method(_OSC,4)
{ {
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3,0,CDW1)
CreateDWordField(Arg3,4,CDW2)
CreateDWordField(Arg3,8,CDW3)
/* Check for proper PCI/PCIe UUID */ /* Check for proper PCI/PCIe UUID */
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} Else { } Else {
CreateDWordField(Arg3,0,CDW1)
Or(CDW1,4,CDW1) // Unrecognized UUID Or(CDW1,4,CDW1) // Unrecognized UUID
Return(Arg3) Return(Arg3)
} }

6
src/southbridge/amd/cimx/sb800/acpi/fch.asl
View File

@ -19,17 +19,13 @@
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method(_OSC,4)
{ {
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3,0,CDW1)
CreateDWordField(Arg3,4,CDW2)
CreateDWordField(Arg3,8,CDW3)
/* Check for proper PCI/PCIe UUID */ /* Check for proper PCI/PCIe UUID */
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} Else { } Else {
CreateDWordField(Arg3,0,CDW1)
Or(CDW1,4,CDW1) // Unrecognized UUID Or(CDW1,4,CDW1) // Unrecognized UUID
Return(Arg3) Return(Arg3)
} }

6
src/southbridge/amd/pi/hudson/acpi/fch.asl
View File

@ -20,17 +20,13 @@
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method(_OSC,4)
{ {
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3,0,CDW1)
CreateDWordField(Arg3,4,CDW2)
CreateDWordField(Arg3,8,CDW3)
/* Check for proper PCI/PCIe UUID */ /* Check for proper PCI/PCIe UUID */
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} Else { } Else {
CreateDWordField(Arg3,0,CDW1)
Or(CDW1,4,CDW1) // Unrecognized UUID Or(CDW1,4,CDW1) // Unrecognized UUID
Return(Arg3) Return(Arg3)
} }