soc/intel/skylake: Split AC/DC settings for Deep Sx config
Currently when enabling Deep S3 or Deep S5 it unconditionally gets enabled in both DC and AC states. However since using Deep S3 disables some expected features like wake-on-USB it is not always desired to enable the same state in both modes. To address this split the setting and add a separate config for Deep Sx in AC and DC states. All motherboards that set this config were updated, but there is no actual change in behavior in this commit. BUG=b:36723679 BRANCH=none TEST=This commit has no runtime visible changes, I verified on Eve that the Deep SX config registers are unchanged, and it compiles for all affected boards. Change-Id: I590f145847785b5a7687f235304e988888fcea8a Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://review.coreboot.org/19239 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Duncan Laurie
parent
bcbba801b8
commit
1fe32d6bb2
|
|
@ -1,8 +1,10 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s3_enable" = "0"
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s3_enable_ac" = "0"
|
||||
register "deep_s3_enable_dc" = "0"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,8 +1,10 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s3_enable" = "1"
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s3_enable_ac" = "1"
|
||||
register "deep_s3_enable_dc" = "1"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,8 +1,10 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Deep Sx states
|
||||
register "deep_s3_enable" = "0"
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s3_enable_ac" = "0"
|
||||
register "deep_s3_enable_dc" = "0"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,8 +1,10 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s3_enable" = "0"
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s3_enable_ac" = "0"
|
||||
register "deep_s3_enable_dc" = "0"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,7 +1,8 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,8 +1,10 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Deep Sx states
|
||||
register "deep_s3_enable" = "0"
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s3_enable_ac" = "0"
|
||||
register "deep_s3_enable_dc" = "0"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,7 +1,8 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s5_enable" = "0"
|
||||
register "deep_s5_enable_ac" = "0"
|
||||
register "deep_s5_enable_dc" = "0"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -7,7 +7,8 @@ chip soc/intel/skylake
|
|||
register "SataPortsEnable[2]" = "1"
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -1,7 +1,8 @@
|
|||
chip soc/intel/skylake
|
||||
|
||||
# Enable deep Sx states
|
||||
register "deep_s5_enable" = "1"
|
||||
register "deep_s5_enable_ac" = "1"
|
||||
register "deep_s5_enable_dc" = "1"
|
||||
register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
|
||||
|
||||
# GPE configuration
|
||||
|
|
|
|||
|
|
@ -610,7 +610,8 @@ int soc_fill_acpi_wake(uint32_t *pm1, uint32_t **gpe0)
|
|||
* Chipset state in the suspend well (but not RTC) is lost in Deep S3
|
||||
* so enable Deep S3 wake events that are configured by the mainboard
|
||||
*/
|
||||
if (ps->prev_sleep_state == ACPI_S3 && config->deep_s3_enable) {
|
||||
if (ps->prev_sleep_state == ACPI_S3 &&
|
||||
(config->deep_s3_enable_ac || config->deep_s3_enable_dc)) {
|
||||
pm1_en |= PWRBTN_STS; /* Always enabled as wake source */
|
||||
if (config->deep_sx_config & DSX_EN_LAN_WAKE_PIN)
|
||||
gpe0_std |= LAN_WAK_EN;
|
||||
|
|
|
|||
|
|
@ -86,9 +86,11 @@ struct soc_intel_skylake_config {
|
|||
/* Enable DPTF support */
|
||||
int dptf_enable;
|
||||
|
||||
/* Deep SX enable for both AC and DC */
|
||||
int deep_s3_enable;
|
||||
int deep_s5_enable;
|
||||
/* Deep SX enables */
|
||||
int deep_s3_enable_ac;
|
||||
int deep_s3_enable_dc;
|
||||
int deep_s5_enable_ac;
|
||||
int deep_s5_enable_dc;
|
||||
|
||||
/*
|
||||
* Deep Sx Configuration
|
||||
|
|
|
|||
|
|
@ -189,16 +189,19 @@ static void config_deep_sX(uint32_t offset, uint32_t mask, int sx, int enable)
|
|||
write32(pmcbase + offset, reg);
|
||||
}
|
||||
|
||||
static void config_deep_s5(int on)
|
||||
static void config_deep_s5(int on_ac, int on_dc)
|
||||
{
|
||||
/* Treat S4 the same as S5. */
|
||||
config_deep_sX(S4_PWRGATE_POL, S4DC_GATE_SUS | S4AC_GATE_SUS, 4, on);
|
||||
config_deep_sX(S5_PWRGATE_POL, S5DC_GATE_SUS | S5AC_GATE_SUS, 5, on);
|
||||
config_deep_sX(S4_PWRGATE_POL, S4AC_GATE_SUS, 4, on_ac);
|
||||
config_deep_sX(S4_PWRGATE_POL, S4DC_GATE_SUS, 4, on_dc);
|
||||
config_deep_sX(S5_PWRGATE_POL, S5AC_GATE_SUS, 5, on_ac);
|
||||
config_deep_sX(S5_PWRGATE_POL, S5DC_GATE_SUS, 5, on_dc);
|
||||
}
|
||||
|
||||
static void config_deep_s3(int on)
|
||||
static void config_deep_s3(int on_ac, int on_dc)
|
||||
{
|
||||
config_deep_sX(S3_PWRGATE_POL, S3DC_GATE_SUS | S3AC_GATE_SUS, 3, on);
|
||||
config_deep_sX(S3_PWRGATE_POL, S3AC_GATE_SUS, 3, on_ac);
|
||||
config_deep_sX(S3_PWRGATE_POL, S3DC_GATE_SUS, 3, on_dc);
|
||||
}
|
||||
|
||||
static void config_deep_sx(uint32_t deepsx_config)
|
||||
|
|
@ -226,8 +229,8 @@ static void pmc_init(struct device *dev)
|
|||
reg_script_run_on_dev(dev, pch_pmc_misc_init_script);
|
||||
pch_set_acpi_mode();
|
||||
|
||||
config_deep_s3(config->deep_s3_enable);
|
||||
config_deep_s5(config->deep_s5_enable);
|
||||
config_deep_s3(config->deep_s3_enable_ac, config->deep_s3_enable_dc);
|
||||
config_deep_s5(config->deep_s5_enable_ac, config->deep_s5_enable_dc);
|
||||
config_deep_sx(config->deep_sx_config);
|
||||
|
||||
/* Clear registers that contain write-1-to-clear bits. */
|
||||
|
|
|
|||
Loading…
Reference in New Issue