From 200f11eb872a55d160b69ab336ff6853f7eee27a Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Thu, 18 Aug 2016 21:29:27 -0700 Subject: [PATCH] intel/apollolake: Fix typo in gpi_status_get sts_index is calculated incorrectly because of wrong use of parenthesis. This lead to wrong bit being checked for EC_SMI_GPI on reef and lidclose event was missed. BUG=chrome-os-partner:56395 BRANCH=None TEST=Verified that lidclose event is seen and handled by SMM in coreboot on reef. Change-Id: I56be4aaf30e2d6712fc597b941206ca59ffaa915 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/16256 Tested-by: build bot (Jenkins) Reviewed-by: Shaunak Saha Reviewed-by: Aaron Durbin --- src/soc/intel/apollolake/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c index 8e4ff3ebf4..a2ac0915ed 100644 --- a/src/soc/intel/apollolake/gpio.c +++ b/src/soc/intel/apollolake/gpio.c @@ -328,7 +328,7 @@ int gpi_status_get(const struct gpi_status *sts, gpio_t gpi) if (comm == NULL) return 0; - sts_index = comm->gpi_offset + (gpi - (comm->first_pad) / + sts_index = comm->gpi_offset + ((gpi - comm->first_pad) / GPIO_MAX_NUM_PER_GROUP); return !!(sts->grp[sts_index] & (1 << (gpi % GPIO_MAX_NUM_PER_GROUP)));