GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/bd82x6x: Rework PCH ID cache 

Work around a romstage restriction. Globals (or static variables) cannot
be initialized to a non-zero value because there's no data section. Note
that the revision ID for stepping A0 is zero, so `pch_silicon_revision`
will no longer use the cached value for this PCH stepping. Since it is a
pre-production stepping, it is most likely not used anywhere anymore.

Change-Id: I07663d151cbc2d2ed7e4813bf870de52848753fd
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49168
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Angel Pons 2021-01-06 14:30:19 +01:00 committed by Felix Singer
parent a506451d9f
commit 20a9533946
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/southbridge/intel/bd82x6x/common.c
View File

@ -14,9 +14,9 @@
int pch_silicon_revision(void) int pch_silicon_revision(void)
{ {
static int pch_revision_id = -1; static int pch_revision_id = 0;
if (pch_revision_id < 0) if (!pch_revision_id)
pch_revision_id = pci_read_config8(PCH_LPC_DEV, PCI_REVISION_ID); pch_revision_id = pci_read_config8(PCH_LPC_DEV, PCI_REVISION_ID);
return pch_revision_id; return pch_revision_id;
@ -24,9 +24,9 @@ int pch_silicon_revision(void)
int pch_silicon_type(void) int pch_silicon_type(void)
{ {
static int pch_type = -1; static int pch_type = 0;
if (pch_type < 0) if (!pch_type)
pch_type = pci_read_config8(PCH_LPC_DEV, PCI_DEVICE_ID + 1); pch_type = pci_read_config8(PCH_LPC_DEV, PCI_DEVICE_ID + 1);
return pch_type; return pch_type;