From 20c64a1210360adc880b8e4fdecc3bb2ae95fb59 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 16 Nov 2022 14:07:43 +0530 Subject: [PATCH] mb/google/rex: Disable `ACPI PM timer` This patch deselects `USE_PM_ACPI_TIMER` kconfig to ensure that ACPI PM timer remains disabled. The PM timer (by PMC IP) consumes more power and blocks S0ix so the timer is emulated by ucode to save power and unblock S0ix. TEST=Able to boot Google, Rex and ensure PMC MMIO register 0x18fc BIT 1 is set. Signed-off-by: Subrata Banik Change-Id: I2a23b417ff7fb6328323380a7df46b4b397fc8eb Reviewed-on: https://review.coreboot.org/c/coreboot/+/69685 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/rex/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 05b47479fb..66e3591bb2 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -106,4 +106,7 @@ config TPM_TIS_ACPI_INTERRUPT int default 35 # GPE0_DW1_03 (GPP_E03) +config USE_PM_ACPI_TIMER + default n + endif # BOARD_GOOGLE_REX_COMMON