GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device: Drop unused function `dev_find_matching_device_on_bus` 

With use of device pointers, `dev_find_matching_device_on_bus()` is
now unused and hence this change drops the function.

Change-Id: I30fcb2d9932d770ca614cceffb15646ce8256465
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57846
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Furquan Shaikh 2021-09-22 13:35:48 -07:00 committed by Paul Fagerburg
parent 0f73791606
commit 20c709daad
2 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/device/device_const.c
View File

@ -70,19 +70,6 @@ DEVTREE_CONST struct device *dev_find_path(
return result;
}
DEVTREE_CONST struct device *dev_find_matching_device_on_bus(const struct bus *bus,
match_device_fn fn)
{
DEVTREE_CONST struct device *child = NULL;
while ((child = dev_bus_each_child(bus, child)) != NULL) {
if (fn(child))
break;
}
return child;
}
/**
* Given a device pointer, find the next PCI device.
*

14
src/include/device/device.h
View File

@ -214,20 +214,6 @@ DEVTREE_CONST struct device *dev_find_path(
enum device_path_type path_type);
struct device *dev_find_lapic(unsigned int apic_id);
int dev_count_cpu(void);
/*
* Signature for matching function that is used by dev_find_matching_device_on_bus() to decide
* if the device being considered is the one that matches the caller's criteria. This function
* is supposed to return true if the provided device matches the criteria, else false.
*/
typedef bool (*match_device_fn)(DEVTREE_CONST struct device *dev);
/*
* Returns the first device on the bus that the match_device_fn returns true for. If no such
* device is found, it returns NULL.
*/
DEVTREE_CONST struct device *dev_find_matching_device_on_bus(const struct bus *bus,
match_device_fn fn);
struct device *add_cpu_device(struct bus *cpu_bus, unsigned int apic_id,
int enabled);
void set_cpu_topology(struct device *cpu, unsigned int node,