From 21530bd421ed286939c32edc8c8cc451ede2e3a7 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Tue, 21 Apr 2020 11:03:11 +0200 Subject: [PATCH] util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes The double quotes around the remaining shell parameters '${@:2}' causes that the provided *.h files in $(CONFIG_CPU_MICROCODE_HEADER_FILES), which is a space separated list, cannot be broken down to every single file as needed but stay as a single parameter in the for-loop. Therefore, the called function 'include_file' will get a single parameter with all files which will lead to a broken C code in terms of a wrong #include-syntax. This causes the script to fail. To fix this remove the double quotes which works just fine. Change-Id: Iab7b0dc8d850973d6af764899907d383e9ec7743 Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/coreboot/+/40565 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- util/scripts/ucode_h_to_bin.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index e6f4699c8f..2010c48e36 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -49,7 +49,7 @@ include_file() { fi } -for UCODE in "${@:2}"; do +for UCODE in ${@:2}; do if [ -d "$UCODE" ]; then for f in "$UCODE/"*.inc do