From 21710ea3cdff6de647a1f507f1e50bf382c2cf14 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 5 Jan 2024 19:16:48 +0100 Subject: [PATCH] cpu/x86/smi_trigger: use enum cb_err as apm_control return type MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even though the return value from apm_control isn't checked at any of its call sites, using the cb_err enum instead of an integer as return type makes it clearer what the returned value means. Signed-off-by: Felix Held Change-Id: I07ced74cae915df52a9d439835b84237d51fdd11 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79835 Reviewed-by: Jérémy Compostella Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Matt DeVillier --- src/cpu/x86/smi_trigger.c | 6 +++--- src/include/cpu/x86/smm.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cpu/x86/smi_trigger.c b/src/cpu/x86/smi_trigger.c index 9781642c74..5c63b9e92a 100644 --- a/src/cpu/x86/smi_trigger.c +++ b/src/cpu/x86/smi_trigger.c @@ -29,11 +29,11 @@ static void apmc_log(const char *fn, u8 cmd) } } -int apm_control(u8 cmd) +enum cb_err apm_control(u8 cmd) { /* Never proceed inside SMI handler or without one. */ if (ENV_SMM || !CONFIG(HAVE_SMI_HANDLER)) - return -1; + return CB_ERR; apmc_log(__func__, cmd); @@ -41,7 +41,7 @@ int apm_control(u8 cmd) outb(cmd, pm_acpi_smi_cmd_port()); printk(BIOS_DEBUG, "APMC done.\n"); - return 0; + return CB_SUCCESS; } u8 apm_get_apmc(void) diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index a240ac2f51..dfb27cd202 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -43,7 +43,7 @@ #endif /* Send cmd to APM_CNT with HAVE_SMI_HANDLER checking. */ -int apm_control(u8 cmd); +enum cb_err apm_control(u8 cmd); u8 apm_get_apmc(void); void io_trap_handler(int smif);