GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Remove wake flag from keyboard IRQ 

The keyboard IRQ was changed to ExclusiveAndWake in order to support
waking from suspend-to-idle (S0ix) with commit
f611fcfaca http://review.coreboot.org/11712

However this is triggering a kernel panic on Windows 10 because it
apparently does not like legacy device interrupts to to be set as
wake capable.

This change is no longer necessary because the linux kernel was
changed to always treat the keyboard as wake capable:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/input/serio/i8042.c?id=f13b2065de8147a1652b830ea5db961cf80c09df

Change-Id: I26e27de68095f8d176108f39312338522d7cfba0
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://review.coreboot.org/23563
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Duncan Laurie 2018-02-02 10:08:22 -08:00 committed by Patrick Georgi
parent 9dc5600f86
commit 2177ccfac9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/google/chromeec/acpi/superio.asl
View File

@ -151,7 +151,7 @@ Device (SIO) {
#ifdef SIO_EC_PS2K_IRQ #ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ
#else #else
IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} IRQ (Edge, ActiveHigh, Exclusive) {1}
#endif #endif
}) })
@ -163,7 +163,7 @@ Device (SIO) {
#ifdef SIO_EC_PS2K_IRQ #ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ
#else #else
IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} IRQ (Edge, ActiveHigh, Exclusive) {1}
#endif #endif
} }
EndDependentFn () EndDependentFn ()