GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/chromeec: Ensure \_SB.LID0 is present before using it 

Since we want to support devices that do not have a lid but still use
EC, we need to conditionally check if referencing \_SB.LID0 is valid.

BUG=b:35775024

Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/18941
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
Furquan Shaikh 2017-03-21 11:20:26 -07:00 committed by Martin Roth
parent ffe58107df
commit 219daafa8f
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ec/google/chromeec/acpi/ec.asl
View File

@ -26,6 +26,9 @@ External (\_SB.DPTF.TEVT, MethodObj)
External (\_SB.DPTF.TCHG, DeviceObj) External (\_SB.DPTF.TCHG, DeviceObj)
#endif #endif
External (\_SB.DPTF.TPET, MethodObj) External (\_SB.DPTF.TPET, MethodObj)
#ifndef EC_ENABLE_LID_SWITCH
External (\_SB.LID0, DeviceObj)
#endif
Device (EC0) Device (EC0)
{ {
@ -169,7 +172,9 @@ Device (EC0)
#ifdef EC_ENABLE_LID_SWITCH #ifdef EC_ENABLE_LID_SWITCH
Notify (LID0, 0x80) Notify (LID0, 0x80)
#else #else
If (CondRefOf (\_SB.LID0)) {
Notify (\_SB.LID0, 0x80) Notify (\_SB.LID0, 0x80)
}
#endif #endif
} }
@ -181,7 +186,9 @@ Device (EC0)
#ifdef EC_ENABLE_LID_SWITCH #ifdef EC_ENABLE_LID_SWITCH
Notify (LID0, 0x80) Notify (LID0, 0x80)
#else #else
If (CondRefOf (\_SB.LID0)) {
Notify (\_SB.LID0, 0x80) Notify (\_SB.LID0, 0x80)
}
#endif #endif
} }