GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/{cezanne,picasso}: Escape PSP_VERSTAGE_FILE default 

If we don't escape the $ then the actual $(obj) path will be written
into the .config file. With this change `$(obj)` is written into the
.config file. The Makefile then does:

    PSP_VERSTAGE_FILE=$(call strip_quotes,$(CONFIG_PSP_VERSTAGE_FILE))

Since this is a recursive assignment the $(obj) will be expanded at that
point.

This change makes it easier to compare full .config files.

BUG=none
TEST=Build ezkinil

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Ic961df148d3f22585f3441d75c3f2454329c678a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56395
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
This commit is contained in:
Raul E Rangel 2021-07-16 14:36:01 -06:00 committed by Raul Rangel
parent 73193cf7b7
commit 21c70b1d0b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/cezanne/Kconfig
View File

@ -379,7 +379,7 @@ config PSP_SOFTFUSE_BITS
config PSP_VERSTAGE_FILE config PSP_VERSTAGE_FILE
string "Specify the PSP_verstage file path" string "Specify the PSP_verstage file path"
depends on VBOOT_STARTS_BEFORE_BOOTBLOCK depends on VBOOT_STARTS_BEFORE_BOOTBLOCK
default "$(obj)/psp_verstage.bin" default "\$(obj)/psp_verstage.bin"
help help
Add psp_verstage file to the build & PSP Directory Table Add psp_verstage file to the build & PSP Directory Table

2
src/soc/amd/picasso/Kconfig
View File

@ -432,7 +432,7 @@ config PSP_UNLOCK_SECURE_DEBUG
config PSP_VERSTAGE_FILE config PSP_VERSTAGE_FILE
string "Specify the PSP_verstage file path" string "Specify the PSP_verstage file path"
depends on VBOOT_STARTS_BEFORE_BOOTBLOCK depends on VBOOT_STARTS_BEFORE_BOOTBLOCK
default "$(obj)/psp_verstage.bin" default "\$(obj)/psp_verstage.bin"
help help
Add psp_verstage file to the build & PSP Directory Table Add psp_verstage file to the build & PSP Directory Table