mb/google/skyrim: Use detect vs probed flag for touchscreens
Now that coreboot performs the necessary power sequencing, switch from using the 'probed' flag to 'detect' for all I2C touchscreens. This alleviates ChromeOS from having to probe to see which touchscreen model is actually present, prevents breaking ACPI spec by generating device entries with status 'enabled and present' which aren't actually present, and improves compatibility with upstream Linux and Windows. BUG=b:121309055 TEST=build/boot ChromeOS and Linux on skyrim, ensure touchscreen is functional, and ACPI device entry generated for correct touchscreen model. Change-Id: Id9e3089decf0f94a1358929684ce248e52cbe41f Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67779 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
This commit is contained in:
parent
b4e94c8b01
commit
22683fabf0
|
@ -49,7 +49,7 @@ chip soc/amd/mendocino
|
|||
register "generic.hid" = ""ELAN9008""
|
||||
register "generic.desc" = ""ELAN Touchscreen""
|
||||
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)"
|
||||
register "generic.probed" = "1"
|
||||
register "generic.detect" = "1"
|
||||
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)"
|
||||
register "generic.enable_delay_ms" = "1"
|
||||
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)"
|
||||
|
|
|
@ -120,7 +120,7 @@ chip soc/amd/mendocino
|
|||
register "generic.hid" = ""GDIX0000""
|
||||
register "generic.desc" = ""Goodix Touchscreen""
|
||||
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)"
|
||||
register "generic.probed" = "1"
|
||||
register "generic.detect" = "1"
|
||||
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)"
|
||||
register "generic.enable_delay_ms" = "10"
|
||||
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)"
|
||||
|
@ -136,7 +136,7 @@ chip soc/amd/mendocino
|
|||
chip drivers/i2c/generic
|
||||
register "hid" = ""ELAN0001""
|
||||
register "desc" = ""ELAN Touchscreen""
|
||||
register "probed" = "1"
|
||||
register "detect" = "1"
|
||||
register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_29)"
|
||||
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)"
|
||||
register "enable_delay_ms" = "1"
|
||||
|
|
|
@ -89,7 +89,7 @@ chip soc/amd/mendocino
|
|||
register "generic.hid" = ""ELAN900C""
|
||||
register "generic.desc" = ""ELAN Touchscreen""
|
||||
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)"
|
||||
register "generic.probed" = "1"
|
||||
register "generic.detect" = "1"
|
||||
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)"
|
||||
register "generic.enable_delay_ms" = "10"
|
||||
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)"
|
||||
|
@ -105,7 +105,7 @@ chip soc/amd/mendocino
|
|||
chip drivers/i2c/generic
|
||||
register "hid" = ""MELF0410""
|
||||
register "desc" = ""Melfas Touchscreen""
|
||||
register "probed" = "1"
|
||||
register "detect" = "1"
|
||||
register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_29)"
|
||||
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)"
|
||||
register "enable_delay_ms" = "1"
|
||||
|
|
Loading…
Reference in New Issue