GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

southbridge/sis: Spelling/comment fixes 

Change-Id: I6a0f5406fb3bc3e8aa3a1111b1d702f530c9329b
Signed-off-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-on: http://review.coreboot.org/7733
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Martin Roth 2014-12-09 13:51:49 -07:00 committed by Martin Roth
parent 474313d1b6
commit 226db05a15
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/southbridge/sis/sis966/lpc.c
View File

@ -185,7 +185,7 @@ static void sis966_lpc_read_resources(device_t dev)
/** /**
* Enable resources for children devices. * Enable resources for children devices.
* *
* @param dev The device whos children's resources are to be enabled. * @param dev The device whose children's resources are to be enabled.
*/ */
static void sis966_lpc_enable_childrens_resources(device_t dev) static void sis966_lpc_enable_childrens_resources(device_t dev)
{ {
@ -212,11 +212,11 @@ static void sis966_lpc_enable_childrens_resources(device_t dev)
reg |= (1<<0); break; reg |= (1<<0); break;
case 0x2f8: // COM2 case 0x2f8: // COM2
reg |= (1<<1); break; reg |= (1<<1); break;
case 0x378: // Parallal 1 case 0x378: // Parallel 1
reg |= (1<<24); break; reg |= (1<<24); break;
case 0x3f0: // FD0 case 0x3f0: // FD0
reg |= (1<<20); break; reg |= (1<<20); break;
case 0x220: // Aduio 0 case 0x220: // Audio 0
reg |= (1<<8); break; reg |= (1<<8); break;
case 0x300: // Midi 0 case 0x300: // Midi 0
reg |= (1<<12); break; reg |= (1<<12); break;

8
src/southbridge/sis/sis966/sis761.c
View File

@ -22,7 +22,7 @@
/* /*
* Turn off machine check triggers when reading * Turn off machine check triggers when reading
* pci space where there are no devices. * pci space where there are no devices.
* This is necessary when scaning the bus for * This is necessary when scanning the bus for
* devices which is done by the kernel * devices which is done by the kernel
* *
* written in 2003 by Eric Biederman * written in 2003 by Eric Biederman
@ -57,13 +57,13 @@ static inline msr_t rdmsr(unsigned index)
/** /**
* Read resources for AGP aperture. * Read resources for AGP aperture.
* *
* There is only one AGP aperture resource needed. The resoruce is added to * There is only one AGP aperture resource needed. The resource is added to
* the northbridge of BSP. * the northbridge of BSP.
* *
* The same trick can be used to augment legacy VGA resources which can * The same trick can be used to augment legacy VGA resources which can
* be detect by generic PCI resource allocator for VGA devices. * be detect by generic PCI resource allocator for VGA devices.
* BAD: it is more tricky than I think, the resource allocation code is * BAD: it is more tricky than I think, the resource allocation code is
* implemented in a way to NOT DOING legacy VGA resource allcation on * implemented in a way to NOT DOING legacy VGA resource allocation on
* purpose :-(. * purpose :-(.
* *
* @param dev TODO * @param dev TODO
@ -74,7 +74,7 @@ static void sis761_read_resources(device_t dev)
printk(BIOS_DEBUG, "sis761_read_resources ------->\n"); printk(BIOS_DEBUG, "sis761_read_resources ------->\n");
pci_dev_read_resources(dev); pci_dev_read_resources(dev);
/* If we are not the first processor don't allocate the gart apeture */ /* If we are not the first processor don't allocate the gart aperture */
if (dev->path.pci.devfn != PCI_DEVFN(0x0, 0)) { if (dev->path.pci.devfn != PCI_DEVFN(0x0, 0)) {
printk(BIOS_DEBUG, "sis761_not_the_first_processor !!!\n"); printk(BIOS_DEBUG, "sis761_not_the_first_processor !!!\n");
return; return;

7
src/southbridge/sis/sis966/sis966.c
View File

@ -180,7 +180,12 @@ void sis966_enable(device_t dev)
if (!dev->enabled) { if (!dev->enabled) {
final_reg |= (1 << index);// disable it final_reg |= (1 << index);// disable it
//The reason for using final_reg, if diable func 1, the func 2 will be func 1 so We need disable them one time. /*
* The reason for using final_reg is that if func 1 is disabled,
* then func 2 will become func 1.
* Because of this, we need loop through disabling them all at
* the same time.
*/
} }
if(index == 9 ) { //NIC1 is the final, We need update final reg to 0xe8 if(index == 9 ) { //NIC1 is the final, We need update final reg to 0xe8