From 22e6018b282c9422c9517632045301ce5fa652ec Mon Sep 17 00:00:00 2001 From: Richard Spiegel Date: Wed, 30 May 2018 17:26:11 -0700 Subject: [PATCH] mb/google/kahlee: Remove #include Because of struct sci_source table of events that have to generate SCI or SMI, was included to kahlee/grunt gpio.c files. However, new code transfered most of SCI/SMI/interrupt programming (with exception of events not associated to a GPIO pin), and therefore smi.h is now included by gpio.h. It was also added to some other files where they are not needed. Only smihandler.c truly needs it. Remove the includes. BUG=b:78139413 TEST=build and boot grunt. Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69 Signed-off-by: Richard Spiegel Reviewed-on: https://review.coreboot.org/26721 Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/mainboard/google/kahlee/mainboard.c | 1 - src/mainboard/google/kahlee/variants/baseboard/gpio.c | 1 - .../kahlee/variants/baseboard/include/baseboard/variants.h | 1 - src/mainboard/google/kahlee/variants/kahlee/gpio.c | 1 - 4 files changed, 4 deletions(-) diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index e090401ddf..6f7882fa1b 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index c7bd6a5be9..4a7cfaef51 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index fc754b5533..23f9cb014c 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -18,7 +18,6 @@ #define __BASEBOARD_VARIANTS_H__ #include -#include #include const struct sci_source *get_gpe_table(size_t *num); diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c index 30723508db..75354deffa 100644 --- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c +++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c @@ -14,7 +14,6 @@ */ #include -#include #include #include #include