From 237ca0d20c932d2e7334a158e4418a69965b845b Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Fri, 17 Mar 2017 11:32:12 +0100 Subject: [PATCH] =?UTF-8?q?mainboards:=20Don=E2=80=99t=20select=20`POST=5F?= =?UTF-8?q?IO`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, it’s impossible for the user to select `NO_POST`, for boards selecting it in their config. ``` warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS) selects POST_IO which has unmet direct dependencies (VENDOR_ASUS && (BOARD_ASUS_F2A85_M || BOARD_ASUS_F2A85_M_PRO || BOARD_ASUS_F2A85_M_LE) && (BOARD_ASUS_F2A85_M || BOARD_ASUS_F2A85_M_PRO) || VENDOR_MSI && BOARD_MSI_MS7721 || PC80_SYSTEM && !NO_POST) ``` This is currently done for Intel Mohon Peak, and its descendants. Selecting the option `POST_IO` in board specific configuration is not a good idea, as this should be user configurable over Kconfig, and also the tree-wide defaults should be the same for these options. Change-Id: Ia4ab0d942b7d66f18466a770ef739109ab0db629 Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/18877 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/mainboard/adi/rcc-dff/Kconfig | 1 - src/mainboard/intel/littleplains/Kconfig | 1 - src/mainboard/intel/mohonpeak/Kconfig | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mainboard/adi/rcc-dff/Kconfig b/src/mainboard/adi/rcc-dff/Kconfig index 2a2afcda8f..3c22a742b0 100644 --- a/src/mainboard/adi/rcc-dff/Kconfig +++ b/src/mainboard/adi/rcc-dff/Kconfig @@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_2048 #actual chip is 8MB select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select POST_IO select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT config MAINBOARD_DIR diff --git a/src/mainboard/intel/littleplains/Kconfig b/src/mainboard/intel/littleplains/Kconfig index 0bd5b86466..10cde71547 100644 --- a/src/mainboard/intel/littleplains/Kconfig +++ b/src/mainboard/intel/littleplains/Kconfig @@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select POST_IO select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT config MAINBOARD_DIR diff --git a/src/mainboard/intel/mohonpeak/Kconfig b/src/mainboard/intel/mohonpeak/Kconfig index 38c99766b2..c354d1bebd 100644 --- a/src/mainboard/intel/mohonpeak/Kconfig +++ b/src/mainboard/intel/mohonpeak/Kconfig @@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_2048 #actual chip is 8MB select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select POST_IO select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT config MAINBOARD_DIR