GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/Kconfig: update help text for 2nd VBIOS ID detection 

The help text for VGA_BIOS_SECOND_ID was outdated and from a time before
we found out that just looking at the CPUID doesn't reliably tell us on
which type of silicon we're running and which VBIOS file to pick, so we
had to use a different method. Update the help text to match what the
code does.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia568771ed7dfa0c7bb850b0efcd2959d7ddfd4a1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73335
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
This commit is contained in:
Felix Held 2023-02-28 17:02:50 +01:00
parent 78cbcefb76
commit 23cae54e5d
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/amd/picasso/Kconfig
View File

@ -243,13 +243,11 @@ config VGA_BIOS_SECOND_ID
string string
default "1002,15dd,c4" default "1002,15dd,c4"
help help
Because Dali and Picasso need different video BIOSes, but have the Some Dali and all Pollock APUs need a different VBIOS than some other
same vendor/device IDs, we need an alternate method to determine the Dali and all Picasso APUs, but don't always have a different PCI
correct video BIOS. In map_oprom_vendev_rev(), we look at the cpuid vendor/device IDs, so we need an alternate method to determine the
and decide which rom to load. correct video BIOS. In map_oprom_vendev_rev(), we look at the return
value of soc_is_raven2() and decide which rom to load.
Even though the hardware has the same vendor/device IDs, the vBIOS
contains a *different* device ID, confusing the situation even more.
config VGA_BIOS_SECOND_FILE config VGA_BIOS_SECOND_FILE
string string