GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

earlymtrr.c: wipe some dead code, use names instead of numbers and some 

cosmetics.

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Acked-by: Stefan Reinauer <stefan.reinauer@coreboot.org>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6499 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Stefan Reinauer 2011-04-14 20:39:49 +00:00 committed by Stefan Reinauer
parent 1fdfed1798
commit 23f49a82f9
1 changed files with 6 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/cpu/x86/mtrr/earlymtrr.c
View File

@ -5,19 +5,6 @@
#include <cpu/amd/mtrr.h> #include <cpu/amd/mtrr.h>
#include <cpu/x86/msr.h> #include <cpu/x86/msr.h>
#if 0
static void disable_var_mtrr(unsigned reg)
{
/* The invalid bit is kept in the mask so we simply
* clear the relevent mask register to disable a
* range.
*/
msr_t zero;
zero.lo = zero.hi = 0;
wrmsr(MTRRphysMask_MSR(reg), zero);
}
#endif
static void set_var_mtrr( static void set_var_mtrr(
unsigned reg, unsigned base, unsigned size, unsigned type) unsigned reg, unsigned base, unsigned size, unsigned type)
@ -28,33 +15,13 @@ static void set_var_mtrr(
basem.lo = base | type; basem.lo = base | type;
basem.hi = 0; basem.hi = 0;
wrmsr(MTRRphysBase_MSR(reg), basem); wrmsr(MTRRphysBase_MSR(reg), basem);
maskm.lo = ~(size - 1) | 0x800; maskm.lo = ~(size - 1) | MTRRphysMaskValid;
maskm.hi = (1<<(CONFIG_CPU_ADDR_BITS-32))-1; maskm.hi = (1 << (CONFIG_CPU_ADDR_BITS - 32)) - 1;
wrmsr(MTRRphysMask_MSR(reg), maskm); wrmsr(MTRRphysMask_MSR(reg), maskm);
} }
#if 0 #if !defined(CONFIG_CACHE_AS_RAM) || (CONFIG_CACHE_AS_RAM == 0)
static void set_var_mtrr_x( static void cache_lbmem(int type)
unsigned reg, uint32_t base_lo, uint32_t base_hi, uint32_t size_lo, uint32_t size_hi, unsigned type)
{
/* Bit Bit 32-35 of MTRRphysMask should be set to 1 */
msr_t basem, maskm;
basem.lo = (base_lo & 0xfffff000) | type;
basem.hi = base_hi & ((1<<(CONFIG_CPU_ADDR_BITS-32))-1);
wrmsr(MTRRphysBase_MSR(reg), basem);
maskm.hi = (1<<(CONFIG_CPU_ADDR_BITS-32))-1;
if(size_lo) {
maskm.lo = ~(size_lo - 1) | 0x800;
} else {
maskm.lo = 0x800;
maskm.hi &= ~(size_hi - 1);
}
wrmsr(MTRRphysMask_MSR(reg), maskm);
}
#endif
static inline void cache_lbmem(int type)
{ {
/* Enable caching for 0 - 1MB using variable mtrr */ /* Enable caching for 0 - 1MB using variable mtrr */
disable_cache(); disable_cache();
@ -62,7 +29,6 @@ static inline void cache_lbmem(int type)
enable_cache(); enable_cache();
} }
#if !defined(CONFIG_CACHE_AS_RAM) || (CONFIG_CACHE_AS_RAM == 0)
/* the fixed and variable MTTRs are power-up with random values, /* the fixed and variable MTTRs are power-up with random values,
* clear them to MTRR_TYPE_UNCACHEABLE for safty. * clear them to MTRR_TYPE_UNCACHEABLE for safty.
*/ */
@ -119,7 +85,6 @@ static inline void early_mtrr_init(void)
do_early_mtrr_init(mtrr_msrs); do_early_mtrr_init(mtrr_msrs);
enable_cache(); enable_cache();
} }
#endif
static inline int early_mtrr_init_detected(void) static inline int early_mtrr_init_detected(void)
{ {
@ -131,7 +96,8 @@ static inline int early_mtrr_init_detected(void)
* according to the documentation. * according to the documentation.
*/ */
msr = rdmsr(MTRRdefType_MSR); msr = rdmsr(MTRRdefType_MSR);
return msr.lo & 0x00000800; return msr.lo & MTRRdefTypeEn;
} }
#endif
#endif /* EARLYMTRR_C */ #endif /* EARLYMTRR_C */