From 24858b0ba0efb0d66325e6dfe432097a005e0da8 Mon Sep 17 00:00:00 2001 From: Maciej Gabryelski Date: Wed, 20 Apr 2022 16:04:28 +0200 Subject: [PATCH] util/ectool/Makefile: improve cross-compilation support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Build variables like CC, INSTALL, and PREFIX, should not be overwritten by the Makefile. This generates problems when we use different buildsystem like Yocto where tool names are stored in environment variables. This change may make building util tool easier - the user of different buildsystem will not have to remember to pass correct tool names during running the make command. Also, this change does not affect the rest of users - if the variable was not set before, then it will be configured as before. Signed-off-by: Maciej Gabryelski Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b Reviewed-on: https://review.coreboot.org/c/coreboot/+/70102 Reviewed-by: Nico Huber Reviewed-by: Michał Żygowski Tested-by: build bot (Jenkins) --- util/ectool/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 8670def922..a90773e5c6 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -1,12 +1,12 @@ ## SPDX-License-Identifier: GPL-2.0-only -CC = gcc +CC ?= gcc WERROR=-Werror CFLAGS = -O2 -Wall -Wextra -Wshadow $(WERROR) PROGRAM = ectool -INSTALL = /usr/bin/env install -PREFIX = /usr/local -OS_ARCH = $(shell uname) +INSTALL ?= /usr/bin/env install +PREFIX ?= /usr/local +OS_ARCH ?= $(shell uname) ifeq ($(shell uname -o 2>/dev/null), Cygwin) LDFLAGS = -lioperm