From 2491d790d2eacf688ac75aeebc32964658feb02e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 12 Sep 2019 21:03:39 +0300 Subject: [PATCH] arch/x86: Remove acpi_fail_wakeup() and cbmem_fail_resume() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unused since commit d46b8d5. Change-Id: If0f1e0381dd7698f842dc1288ff222a4d5d4783c Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/35389 Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/arch/x86/acpi_s3.c | 6 ------ src/arch/x86/cbmem.c | 11 ----------- src/arch/x86/include/arch/acpi.h | 1 - src/include/cbmem.h | 1 - src/lib/cbmem_common.c | 4 ---- 5 files changed, 23 deletions(-) diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c index 5553b2cc41..52f8a201f7 100644 --- a/src/arch/x86/acpi_s3.c +++ b/src/arch/x86/acpi_s3.c @@ -60,12 +60,6 @@ int acpi_is_wakeup_s4(void) acpi_handoff_wakeup(); return (acpi_slp_type == ACPI_S4); } - -void acpi_fail_wakeup(void) -{ - if (acpi_slp_type == ACPI_S3 || acpi_slp_type == ACPI_S2) - acpi_slp_type = ACPI_S0; -} #endif /* ENV_RAMSTAGE */ #define WAKEUP_BASE 0x600 diff --git a/src/arch/x86/cbmem.c b/src/arch/x86/cbmem.c index 648633f070..16c35b5dea 100644 --- a/src/arch/x86/cbmem.c +++ b/src/arch/x86/cbmem.c @@ -13,7 +13,6 @@ #include #include -#include #if CONFIG(CBMEM_TOP_BACKUP) @@ -35,13 +34,3 @@ void *cbmem_top(void) } #endif /* CBMEM_TOP_BACKUP */ - -/* Something went wrong, our high memory area got wiped */ -void cbmem_fail_resume(void) -{ -#if !defined(__PRE_RAM__) && CONFIG(HAVE_ACPI_RESUME) - /* ACPI resume needs to be cleared in the fail-to-recover case, but that - * condition is only handled during ramstage. */ - acpi_fail_wakeup(); -#endif -} diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 14f0cdf9ab..42e45fb32f 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -932,7 +932,6 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, acpi_hest_esd_t *esd, u16 type, void *data, u16 len); /* For ACPI S3 support. */ -void acpi_fail_wakeup(void); void acpi_resume(void *wake_vec); void mainboard_suspend_resume(void); void *acpi_find_wakeup_vector(void); diff --git a/src/include/cbmem.h b/src/include/cbmem.h index f3df21d430..f972ba6503 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -106,7 +106,6 @@ void *cbmem_find(u32 id); /* Indicate to each hook if cbmem is being recovered or not. */ typedef void (* const cbmem_init_hook_t)(int is_recovery); void cbmem_run_init_hooks(int is_recovery); -void cbmem_fail_resume(void); /* Ramstage only functions. */ /* Add the cbmem memory used to the memory map at boot. */ diff --git a/src/lib/cbmem_common.c b/src/lib/cbmem_common.c index d86edf013a..b018acb4fa 100644 --- a/src/lib/cbmem_common.c +++ b/src/lib/cbmem_common.c @@ -32,7 +32,3 @@ void cbmem_run_init_hooks(int is_recovery) init_hook_ptr++; } } - -void __weak cbmem_fail_resume(void) -{ -}