From 250988d943c322ac1720ae7cd6f88592f82a08c0 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 20 Oct 2021 20:45:28 +0200 Subject: [PATCH] soc/amd/common/block/cpu/smm/finalize: simplify finalize_cores The local variable int r isn't needed, so remove it. This is a preparation to change the return type of mp_run_on_all_cpus from int to enum cb_err which will be done in a follow-up patch. Signed-off-by: Felix Held Change-Id: Ie4c454cbfcc581be41ea3463ea6f852a72886128 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58493 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Arthur Heymans --- src/soc/amd/common/block/cpu/smm/finalize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/soc/amd/common/block/cpu/smm/finalize.c b/src/soc/amd/common/block/cpu/smm/finalize.c index 2df55247cf..2795100d86 100644 --- a/src/soc/amd/common/block/cpu/smm/finalize.c +++ b/src/soc/amd/common/block/cpu/smm/finalize.c @@ -29,11 +29,9 @@ static void per_core_finalize(void *unused) static void finalize_cores(void) { - int r; printk(BIOS_SPEW, "Lock SMM configuration\n"); - r = mp_run_on_all_cpus(per_core_finalize, NULL); - if (r) + if (mp_run_on_all_cpus(per_core_finalize, NULL)) printk(BIOS_WARNING, "Failed to finalize all cores\n"); }