GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0/hand_off_block: use iterator in fsp_find_range_hob 

Drop the find_resource_hob_by_guid implementation and use the new
fsp_hob_iterator_init and fsp_hob_iterator_get_next_guid_resource
functions in fsp_find_range_hob.

TEST=Mandolin still finds the TSEG range HOB and uses the correct TSEG
location.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I00786cbeea203fba195ddc953c3242be544a7d70
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69477
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Felix Held 2022-11-12 01:42:39 +01:00
parent 2e81436be8
commit 2516947fd9
1 changed files with 3 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/drivers/intel/fsp2_0/hand_off_block.c
View File

@ -190,23 +190,6 @@ enum cb_err fsp_hob_iterator_get_next_guid_extension(const struct hob_header **h
return CB_ERR; return CB_ERR;
} }
static const
struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob,
const uint8_t guid[16])
{
const struct hob_resource *res;
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR)
continue;
res = fsp_hob_header_to_resource(hob);
if (fsp_guid_compare(res->owner_guid, guid))
return res;
}
return NULL;
}
void fsp_print_guid(const void *base) void fsp_print_guid(const void *base)
{ {
uint32_t big; uint32_t big;
@ -224,17 +207,15 @@ void fsp_print_guid(const void *base)
int fsp_find_range_hob(struct range_entry *re, const uint8_t guid[16]) int fsp_find_range_hob(struct range_entry *re, const uint8_t guid[16])
{ {
const struct hob_header *hob_iterator;
const struct hob_resource *fsp_mem; const struct hob_resource *fsp_mem;
const void *hob_list = fsp_get_hob_list();
if (!hob_list) if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS)
return -1; return -1;
range_entry_init(re, 0, 0, 0); range_entry_init(re, 0, 0, 0);
fsp_mem = find_resource_hob_by_guid(hob_list, guid); if (fsp_hob_iterator_get_next_guid_resource(&hob_iterator, guid, &fsp_mem) != CB_SUCCESS) {
if (!fsp_mem) {
fsp_print_guid(guid); fsp_print_guid(guid);
printk(BIOS_SPEW, " not found!\n"); printk(BIOS_SPEW, " not found!\n");
return -1; return -1;