GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/samsung/lumpy/romstage: read SPD data of removable DIMM 

The removable DIMM SPD data wasn't read.
As a result the system only uses the 2GB onboard memory and
the GNU Linux kernel paniced in acpi_ds_build_internal_package_obj.

Read the SPD and allow native raminit and MRC blob to use the
removable DIMM.
The system is able to use the removable dimm and the kernel panic
is gone.

Change-Id: I30eed747f924cb0029de55d2ab85c5a94075dc1b
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: Idwer Vollering <vidwer@gmail.com>
Reviewed-on: https://review.coreboot.org/14278
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Patrick Rudolph 2016-04-07 18:51:12 +02:00 committed by Martin Roth
parent ba3a69f9c7
commit 25852099ee
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mainboard/samsung/lumpy/romstage.c
View File

@ -216,6 +216,8 @@ void mainboard_fill_pei_data(struct pei_data *pei_data)
*pei_data = pei_data_template;
// leave onboard dimm address at f0, and copy spd data there.
memcpy(pei_data->spd_data[0], locate_spd(), 256);
/* read removable dimm spd */
read_spd(&pei_data->spd_data[2], 0x50);
}
const struct southbridge_usb_port mainboard_usb_ports[] = {
@ -238,7 +240,10 @@ const struct southbridge_usb_port mainboard_usb_ports[] = {
void mainboard_get_spd(spd_raw_data *spd)
{
memcpy(&spd[0], locate_spd(), 128);
/* get onboard dimm spd */
memcpy(&spd[0], locate_spd(), 256);
/* read removable dimm spd */
read_spd(&spd[2], 0x50);
}
void mainboard_early_init(int s3resume)