soc/intel: Set `use_eisa_hids` based on `DPTF_USE_EISA_HID` config
This patch avoids hardcoding to the `use_eisa_hids` variable instead relying on the SoC config to choose if the SoC platform supports EISA HID. If any SoC platform has the support then the `use_eisa_hids` variable would be set to `true` based on the selection of `DPTF_USE_EISA_HID` config. Note: Prior to Tiger Lake, all DPTF devices used 7-character EISA IDs. If selected, the 7-character _HIDs will be emitted, otherwise, it will use the "new" style, which are regular 8-character _HIDs. Ideally, the platform prior to Tiger Lake would set `use_eisa_hids` to `true` and platform posts that would set `use_eisa_hids` to `false`. Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: I869bebc8e17c1e65979ca3431308d69771a34fa3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/71110 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Reviewed-by: Tarun Tuli <taruntuli@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
parent
4225a796fa
commit
2585a999bb
|
@ -4,7 +4,7 @@
|
||||||
#include <soc/dptf.h>
|
#include <soc/dptf.h>
|
||||||
|
|
||||||
static const struct dptf_platform_info adl_dptf_platform_info = {
|
static const struct dptf_platform_info adl_dptf_platform_info = {
|
||||||
.use_eisa_hids = false,
|
.use_eisa_hids = CONFIG(DPTF_USE_EISA_HID),
|
||||||
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
||||||
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
||||||
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
||||||
|
|
|
@ -4,7 +4,7 @@
|
||||||
#include <soc/dptf.h>
|
#include <soc/dptf.h>
|
||||||
|
|
||||||
static const struct dptf_platform_info apl_dptf_platform_info = {
|
static const struct dptf_platform_info apl_dptf_platform_info = {
|
||||||
.use_eisa_hids = true,
|
.use_eisa_hids = CONFIG(DPTF_USE_EISA_HID),
|
||||||
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
||||||
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
||||||
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
||||||
|
|
|
@ -4,7 +4,7 @@
|
||||||
#include <soc/dptf.h>
|
#include <soc/dptf.h>
|
||||||
|
|
||||||
static const struct dptf_platform_info cnl_dptf_platform_info = {
|
static const struct dptf_platform_info cnl_dptf_platform_info = {
|
||||||
.use_eisa_hids = true,
|
.use_eisa_hids = CONFIG(DPTF_USE_EISA_HID),
|
||||||
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
||||||
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
||||||
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
||||||
|
|
|
@ -4,7 +4,7 @@
|
||||||
#include <soc/dptf.h>
|
#include <soc/dptf.h>
|
||||||
|
|
||||||
static const struct dptf_platform_info jsl_dptf_platform_info = {
|
static const struct dptf_platform_info jsl_dptf_platform_info = {
|
||||||
.use_eisa_hids = true,
|
.use_eisa_hids = CONFIG(DPTF_USE_EISA_HID),
|
||||||
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
||||||
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
||||||
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
||||||
|
|
|
@ -5,7 +5,7 @@
|
||||||
#include <stdbool.h>
|
#include <stdbool.h>
|
||||||
|
|
||||||
static const struct dptf_platform_info tgl_dptf_platform_info = {
|
static const struct dptf_platform_info tgl_dptf_platform_info = {
|
||||||
.use_eisa_hids = false,
|
.use_eisa_hids = CONFIG(DPTF_USE_EISA_HID),
|
||||||
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
/* _HID for the toplevel DPTF device, typically \_SB.DPTF */
|
||||||
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
.dptf_device_hid = DPTF_DPTF_DEVICE,
|
||||||
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
/* _HID for Intel DPTF Generic Device (these require PTYP as well) */
|
||||||
|
|
Loading…
Reference in New Issue