GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism/librem_whl: Drop 3Gbps SATA limit; enable and set SATA tuning params 

Some Librem Minis exhibit issues with 6Gbps SATA operation on certain
SSDs, setting the Receiver Equalization Boost Magnitude adjustment
resolves this, so limiting SATA speeds to 3Gbps is no longer needed.

Test: build/boot Librem Mini with Crucial SATA SSD, observe no issues
booting, no ATA-related errors in dmesg on PureOS 10 / kernel 5.8.7

Change-Id: I8b3cbcff7f181bcab35d71e859033578c822bb20
Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45696
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2020-09-23 17:15:34 -05:00 committed by Patrick Georgi
parent b5eae2868b
commit 25a2ca9628
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/purism/librem_whl/ramstage.c
View File

@ -10,7 +10,4 @@ void mainboard_silicon_init_params(FSP_S_CONFIG *params)
size_t num_gpios; size_t num_gpios;
const struct pad_config *gpio_table = variant_gpio_table(&num_gpios); const struct pad_config *gpio_table = variant_gpio_table(&num_gpios);
cnl_configure_pads(gpio_table, num_gpios); cnl_configure_pads(gpio_table, num_gpios);
/* Limit SATA speed to 3Gbps until correct HSIO PHY settings determined */
params->SataSpeedLimit = 2;
} }

9
src/mainboard/purism/librem_whl/romstage.c
View File

@ -48,5 +48,12 @@ static const struct cnl_mb_cfg memcfg = {
void mainboard_memory_init_params(FSPM_UPD *memupd) void mainboard_memory_init_params(FSPM_UPD *memupd)
{ {
cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg); FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig;
cannonlake_memcfg_init(mem_cfg, &memcfg);
/* Enable and set SATA HSIO adjustments for ports 0 and 2 */
mem_cfg->PchSataHsioRxGen3EqBoostMagEnable[0] = 1;
mem_cfg->PchSataHsioRxGen3EqBoostMagEnable[2] = 1;
mem_cfg->PchSataHsioRxGen3EqBoostMag[0] = 2;
mem_cfg->PchSataHsioRxGen3EqBoostMag[2] = 1;
} }