GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/{bd82x6x,ibexpeak,lynxpoint}/early_smbus: Use macro 

Change-Id: If57d785b92f0f09d9def90b8ac87833321e3cfcf
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40225
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes HAOUAS 2020-04-06 09:12:50 +02:00 committed by Angel Pons
parent 200f02a518
commit 25d20d3332
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/southbridge/intel/bd82x6x/early_smbus.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* This file is part of the coreboot project. */ /* This file is part of the coreboot project. */
#include <device/pci_ids.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/smbus_host.h> #include <device/smbus_host.h>
@ -17,7 +18,7 @@ int smbus_enable_iobar(uintptr_t base)
pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3); pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3);
/* Check to make sure we've got the right device. */ /* Check to make sure we've got the right device. */
if (pci_read_config16(dev, 0x0) != 0x8086) if (pci_read_config16(dev, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL)
return -1; return -1;
/* Set SMBus I/O base. */ /* Set SMBus I/O base. */

3
src/southbridge/intel/ibexpeak/early_smbus.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* This file is part of the coreboot project. */ /* This file is part of the coreboot project. */
#include <device/pci_ids.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/smbus_host.h> #include <device/smbus_host.h>
@ -17,7 +18,7 @@ int smbus_enable_iobar(uintptr_t base)
pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3); pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3);
/* Check to make sure we've got the right device. */ /* Check to make sure we've got the right device. */
if (pci_read_config16(dev, 0x0) != 0x8086) if (pci_read_config16(dev, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL)
return -1; return -1;
/* Set SMBus I/O base. */ /* Set SMBus I/O base. */

3
src/southbridge/intel/lynxpoint/early_smbus.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* This file is part of the coreboot project. */ /* This file is part of the coreboot project. */
#include <device/pci_ids.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/smbus_host.h> #include <device/smbus_host.h>
@ -17,7 +18,7 @@ int smbus_enable_iobar(uintptr_t base)
pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3); pci_devfn_t dev = PCI_DEV(0x0, 0x1f, 0x3);
/* Check to make sure we've got the right device. */ /* Check to make sure we've got the right device. */
if (pci_read_config16(dev, 0x0) != 0x8086) if (pci_read_config16(dev, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL)
return -1; return -1;
/* Set SMBus I/O base. */ /* Set SMBus I/O base. */