GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/drivers/i2c/rx6110sa: Omit _HID temporarily 

The current HID "RX6110SA" does not comply with the ACPI spec in terms
of the naming convention where the first three caracters should be a
vendor ID and the last 4 characters should be a device ID. For now
there is a vendor ID for Epson (SEC) but there is none for this
particular RTC. In order to avoid the reporting of a non ACPI-compliant
HID it will be dropped completely for now.

Once Epson has assigned a valid HID for this RTC, this valid HID will be
used here instead.

Change-Id: Ib77ffad084c25f60f79ec7d503f14731b1ebe9e2
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47706
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Werner Zeh 2020-11-18 13:57:35 +01:00
parent b8c7ea0f69
commit 2609eaaa8f
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/drivers/i2c/rx6110sa/rx6110sa.c
View File

@ -198,7 +198,6 @@ static void rx6110sa_fill_ssdt(const struct device *dev)
/* Device */ /* Device */
acpigen_write_scope(scope); acpigen_write_scope(scope);
acpigen_write_device(acpi_device_name(dev)); acpigen_write_device(acpi_device_name(dev));
acpigen_write_name_string("_HID", RX6110SA_HID_NAME);
acpigen_write_name_string("_DDN", RX6110SA_HID_DESC); acpigen_write_name_string("_DDN", RX6110SA_HID_DESC);
acpigen_write_STA(acpi_device_status(dev)); acpigen_write_STA(acpi_device_status(dev));

1
src/drivers/i2c/rx6110sa/rx6110sa.h
View File

@ -4,7 +4,6 @@
#define _I2C_RX6110SA_H_ #define _I2C_RX6110SA_H_
#define RX6110SA_ACPI_NAME "ERX6" #define RX6110SA_ACPI_NAME "ERX6"
#define RX6110SA_HID_NAME "RX6110SA"
#define RX6110SA_HID_DESC "Real Time Clock" #define RX6110SA_HID_DESC "Real Time Clock"
/* Register layout */ /* Register layout */