GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sunw/ultra40m2: Fix handling non-existence of a device 

This probably never happens, but since we already test for the presence
of the device, it makes no sense to try to configure it after its
absense was determined.

Change-Id: I9877dcd15819fb7949fa08a0954b05780df66316
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1347362
Reviewed-on: https://review.coreboot.org/15982
Tested-by: build bot (Jenkins)
Reviewed-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Patrick Georgi 2016-07-30 13:10:44 +02:00 committed by Martin Roth
parent 1fcebe7fd9
commit 2660a1321a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/sunw/ultra40m2/mainboard.c
View File

@ -52,8 +52,10 @@ static void emc6d103_init(void)
};
struct device * const dev = dev_find_slot_on_smbus(2, 0x2d);
if (dev == NULL)
if (dev == NULL) {
printk(BIOS_WARNING, "EMC6D103 not found\n");
return;
}
printk(BIOS_SPEW, "%s EMC6D103 id: %x %x\n", __func__, smbus_read_byte(dev, 0x3e), smbus_read_byte(dev, 0x3f));