nb/intel/raminit (native): Read PCI mmio size from devicetree

Instead of hardcoding the PCI mmio size read it from devicetree.
Set a default value of 2048 MiB and 1024MiB for laptops without
discrete graphics.

Tested on Sandybridge Lenovo T520.

Change-Id: I791ebd6897c5ba4e2e18bd307d320568b1378a13
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/15140
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Patrick Rudolph 2016-06-09 18:13:34 +02:00 committed by Martin Roth
parent e7f35cd292
commit 266a1f794d
24 changed files with 120 additions and 3 deletions

View File

@ -30,6 +30,9 @@ chip northbridge/intel/sandybridge
end end
end end
end end
register "pci_mmio_size" = "2048"
device domain 0x0 on device domain 0x0 on
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH
register "c2_latency" = "0x0065" register "c2_latency" = "0x0065"

View File

@ -19,6 +19,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
subsystemid 0x1458 0x5000 inherit subsystemid 0x1458 0x5000 inherit
device pci 00.0 on # host bridge device pci 00.0 on # host bridge

View File

@ -18,6 +18,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
subsystemid 0x1458 0x5000 inherit subsystemid 0x1458 0x5000 inherit
device pci 00.0 on # host bridge device pci 00.0 on # host bridge

View File

@ -42,6 +42,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
subsystemid 0x1ae0 0xc000 inherit subsystemid 0x1ae0 0xc000 inherit
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge

View File

@ -23,6 +23,8 @@ chip northbridge/intel/gm45
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x20e0 subsystemid 0x17aa 0x20e0

View File

@ -36,6 +36,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x21ce subsystemid 0x17aa 0x21ce

View File

@ -35,6 +35,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x21d2 subsystemid 0x17aa 0x21d2

View File

@ -35,6 +35,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x21fb subsystemid 0x17aa 0x21fb

View File

@ -36,6 +36,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge
device pci 01.0 on end # NVIDIA Corporation GF119M [NVS 4200M] device pci 01.0 on end # NVIDIA Corporation GF119M [NVS 4200M]

View File

@ -36,6 +36,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge
device pci 01.0 on end # PCIe Bridge for discrete graphics device pci 01.0 on end # PCIe Bridge for discrete graphics

View File

@ -28,6 +28,8 @@ chip northbridge/intel/gm45
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x20e0 subsystemid 0x17aa 0x20e0

View File

@ -80,6 +80,8 @@ chip northbridge/intel/nehalem
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
device pci 00.0 on # Host bridge device pci 00.0 on # Host bridge
subsystemid 0x17aa 0x2193 subsystemid 0x17aa 0x2193

View File

@ -36,6 +36,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x21db subsystemid 0x17aa 0x21db

View File

@ -36,6 +36,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x21fa subsystemid 0x17aa 0x21fa

View File

@ -42,6 +42,8 @@ chip northbridge/intel/nehalem
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
device pci 00.0 on # Host bridge device pci 00.0 on # Host bridge
subsystemid 0x1025 0x0379 subsystemid 0x1025 0x0379

View File

@ -19,6 +19,8 @@ chip northbridge/intel/gm45
end end
end end
register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
subsystemid 0x4352 0x8986 subsystemid 0x4352 0x8986
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge

View File

@ -34,6 +34,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
ioapic_irq 4 INTA 0x10 ioapic_irq 4 INTA 0x10
ioapic_irq 4 INTB 0x11 ioapic_irq 4 INTB 0x11

View File

@ -32,6 +32,8 @@ chip northbridge/intel/sandybridge
end end
end end
register "pci_mmio_size" = "1024"
device domain 0 on device domain 0 on
subsystemid 0x1ae0 0xc000 inherit subsystemid 0x1ae0 0xc000 inherit
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge

View File

@ -26,6 +26,11 @@ struct northbridge_intel_gm45_config {
u16 gpu_panel_power_backlight_off_delay; /* Tx time sequence */ u16 gpu_panel_power_backlight_off_delay; /* Tx time sequence */
u8 gpu_panel_power_cycle_delay; /* T4 time sequence */ u8 gpu_panel_power_cycle_delay; /* T4 time sequence */
struct i915_gpu_controller_info gfx; struct i915_gpu_controller_info gfx;
/*
* Maximum PCI mmio size in MiB.
*/
u16 pci_mmio_size;
}; };
#endif /* NORTHBRIDGE_INTEL_GM45_CHIP_H */ #endif /* NORTHBRIDGE_INTEL_GM45_CHIP_H */

View File

@ -20,11 +20,13 @@
#include <arch/io.h> #include <arch/io.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/pnp_def.h> #include <device/pnp_def.h>
#include <device/device.h>
#include <spd.h> #include <spd.h>
#include <console/console.h> #include <console/console.h>
#include <lib.h> #include <lib.h>
#include "delay.h" #include "delay.h"
#include "gm45.h" #include "gm45.h"
#include "chip.h"
static const gmch_gfx_t gmch_gfx_types[][5] = { static const gmch_gfx_t gmch_gfx_types[][5] = {
/* MAX_667MHz MAX_533MHz MAX_400MHz MAX_333MHz MAX_800MHz */ /* MAX_667MHz MAX_533MHz MAX_400MHz MAX_333MHz MAX_800MHz */
@ -1156,6 +1158,25 @@ static void vc1_program_timings(const fsb_clock_t fsb)
EPBAR32(0x3c) = timings_by_fsb[fsb][1]; EPBAR32(0x3c) = timings_by_fsb[fsb][1];
} }
#define DEFAULT_PCI_MMIO_SIZE 2048
#define HOST_BRIDGE PCI_DEVFN(0, 0)
static unsigned int get_mmio_size(void)
{
const struct device *dev;
const struct northbridge_intel_gm45_config *cfg = NULL;
dev = dev_find_slot(0, HOST_BRIDGE);
if (dev)
cfg = dev->chip_info;
/* If this is zero, it just means devicetree.cb didn't set it */
if (!cfg || cfg->pci_mmio_size == 0)
return DEFAULT_PCI_MMIO_SIZE;
else
return cfg->pci_mmio_size;
}
/* @prejedec if not zero, set rank size to 128MB and page size to 4KB. */ /* @prejedec if not zero, set rank size to 128MB and page size to 4KB. */
static void program_memory_map(const dimminfo_t *const dimms, const channel_mode_t mode, const int prejedec, u16 ggc) static void program_memory_map(const dimminfo_t *const dimms, const channel_mode_t mode, const int prejedec, u16 ggc)
{ {
@ -1226,7 +1247,8 @@ static void program_memory_map(const dimminfo_t *const dimms, const channel_mode
} }
} }
const unsigned int MMIOstart = 0x0c00 + uma_sizem; /* 3GB, makes MTRR configuration small. */ const unsigned int mmio_size = get_mmio_size();
const unsigned int MMIOstart = 4096 - mmio_size + uma_sizem;
const int me_active = pci_read_config8(PCI_DEV(0, 3, 0), PCI_CLASS_REVISION) != 0xff; const int me_active = pci_read_config8(PCI_DEV(0, 3, 0), PCI_CLASS_REVISION) != 0xff;
const unsigned int ME_SIZE = prejedec || !me_active ? 0 : 32; const unsigned int ME_SIZE = prejedec || !me_active ? 0 : 32;
const unsigned int usedMEsize = (total_mb[0] != total_mb[1]) ? ME_SIZE : 2 * ME_SIZE; const unsigned int usedMEsize = (total_mb[0] != total_mb[1]) ? ME_SIZE : 2 * ME_SIZE;

View File

@ -41,6 +41,11 @@ struct northbridge_intel_nehalem_config {
u32 gpu_pch_backlight; /* PCH Backlight PWM value */ u32 gpu_pch_backlight; /* PCH Backlight PWM value */
struct i915_gpu_controller_info gfx; struct i915_gpu_controller_info gfx;
/*
* Maximum PCI mmio size in MiB.
*/
u16 pci_mmio_size;
}; };
#endif /* NORTHBRIDGE_INTEL_NEHALEM_CHIP_H */ #endif /* NORTHBRIDGE_INTEL_NEHALEM_CHIP_H */

View File

@ -32,10 +32,12 @@
#include <ip_checksum.h> #include <ip_checksum.h>
#include <pc80/mc146818rtc.h> #include <pc80/mc146818rtc.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/device.h>
#include <arch/cpu.h> #include <arch/cpu.h>
#include <halt.h> #include <halt.h>
#include <spd.h> #include <spd.h>
#include "raminit.h" #include "raminit.h"
#include "chip.h"
#include <timestamp.h> #include <timestamp.h>
#include <cpu/x86/mtrr.h> #include <cpu/x86/mtrr.h>
#include <cpu/intel/speedstep.h> #include <cpu/intel/speedstep.h>
@ -1450,6 +1452,25 @@ static void program_board_delay(struct raminfo *info)
} }
} }
#define DEFAULT_PCI_MMIO_SIZE 2048
#define HOST_BRIDGE PCI_DEVFN(0, 0)
static unsigned int get_mmio_size(void)
{
const struct device *dev;
const struct northbridge_intel_nehalem_config *cfg = NULL;
dev = dev_find_slot(0, HOST_BRIDGE);
if (dev)
cfg = dev->chip_info;
/* If this is zero, it just means devicetree.cb didn't set it */
if (!cfg || cfg->pci_mmio_size == 0)
return DEFAULT_PCI_MMIO_SIZE;
else
return cfg->pci_mmio_size;
}
#define BETTER_MEMORY_MAP 0 #define BETTER_MEMORY_MAP 0
static void program_total_memory_map(struct raminfo *info) static void program_total_memory_map(struct raminfo *info)
@ -1459,6 +1480,7 @@ static void program_total_memory_map(struct raminfo *info)
unsigned int REMAPbase; unsigned int REMAPbase;
unsigned int uma_base_igd; unsigned int uma_base_igd;
unsigned int uma_base_gtt; unsigned int uma_base_gtt;
unsigned int mmio_size;
int memory_remap; int memory_remap;
unsigned int memory_map[8]; unsigned int memory_map[8];
int i; int i;
@ -1485,11 +1507,13 @@ static void program_total_memory_map(struct raminfo *info)
} }
#endif #endif
mmio_size = get_mmio_size();
TOM = info->total_memory_mb; TOM = info->total_memory_mb;
if (TOM == 4096) if (TOM == 4096)
TOM = 4032; TOM = 4032;
TOUUD = ALIGN_DOWN(TOM - info->memory_reserved_for_heci_mb, 64); TOUUD = ALIGN_DOWN(TOM - info->memory_reserved_for_heci_mb, 64);
TOLUD = ALIGN_DOWN(min(3072 + ALIGN_UP(uma_size_igd + uma_size_gtt, 64) TOLUD = ALIGN_DOWN(min(4096 - mmio_size + ALIGN_UP(uma_size_igd + uma_size_gtt, 64)
, TOUUD), 64); , TOUUD), 64);
memory_remap = 0; memory_remap = 0;
if (TOUUD - TOLUD > 64) { if (TOUUD - TOLUD > 64) {

View File

@ -47,6 +47,11 @@ struct northbridge_intel_sandybridge_config {
u16 max_mem_clock_mhz; u16 max_mem_clock_mhz;
struct i915_gpu_controller_info gfx; struct i915_gpu_controller_info gfx;
/*
* Maximum PCI mmio size in MiB.
*/
u16 pci_mmio_size;
}; };
#endif /* NORTHBRIDGE_INTEL_SANDYBRIDGE_CHIP_H */ #endif /* NORTHBRIDGE_INTEL_SANDYBRIDGE_CHIP_H */

View File

@ -204,6 +204,7 @@ typedef struct ramctr_timing_st {
#define GET_ERR_CHANNEL(x) (x>>16) #define GET_ERR_CHANNEL(x) (x>>16)
static void program_timings(ramctr_timing * ctrl, int channel); static void program_timings(ramctr_timing * ctrl, int channel);
static unsigned int get_mmio_size(void);
static const char *ecc_decoder[] = { static const char *ecc_decoder[] = {
"inactive", "inactive",
@ -1086,7 +1087,7 @@ static void dram_memorymap(ramctr_timing * ctrl, int me_uma_size)
size_t tsegbasedelta, remapbase, remaplimit; size_t tsegbasedelta, remapbase, remaplimit;
uint16_t ggc; uint16_t ggc;
mmiosize = 0x400; mmiosize = get_mmio_size();
ggc = pci_read_config16(NORTHBRIDGE, GGC); ggc = pci_read_config16(NORTHBRIDGE, GGC);
if (!(ggc & 2)) { if (!(ggc & 2)) {
@ -4384,6 +4385,24 @@ static unsigned int get_mem_min_tck(void)
} }
} }
#define DEFAULT_PCI_MMIO_SIZE 2048
static unsigned int get_mmio_size(void)
{
const struct device *dev;
const struct northbridge_intel_sandybridge_config *cfg = NULL;
dev = dev_find_slot(0, HOST_BRIDGE);
if (dev)
cfg = dev->chip_info;
/* If this is zero, it just means devicetree.cb didn't set it */
if (!cfg || cfg->pci_mmio_size == 0)
return DEFAULT_PCI_MMIO_SIZE;
else
return cfg->pci_mmio_size;
}
void perform_raminit(int s3resume) void perform_raminit(int s3resume)
{ {
spd_raw_data spd[4]; spd_raw_data spd[4];