From 26a8dea551befff05ed1082c808851ee176291ec Mon Sep 17 00:00:00 2001 From: Liju-Clr Chen Date: Thu, 15 Dec 2022 13:40:41 +0800 Subject: [PATCH] mb/google/geralt: Revise the naming of MIPI PWM control GPIO Rename the MIPI PWM control GPIO to be consistent with the schematic. BUG=b:244208960 TEST=test firmware display pass for eDP and MIPI panels on MT8188 EVB Change-Id: I6a3368d438cb50b257992260d1388f0b7e0f5ace Signed-off-by: Liju-Clr Chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/70822 Reviewed-by: Yidi Lin Reviewed-by: Rex-BC Chen Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/mainboard/google/geralt/gpio.h | 2 +- src/mainboard/google/geralt/panel_geralt.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/geralt/gpio.h b/src/mainboard/google/geralt/gpio.h index 5f55917664..864b3f9b2b 100644 --- a/src/mainboard/google/geralt/gpio.h +++ b/src/mainboard/google/geralt/gpio.h @@ -18,7 +18,7 @@ #define GPIO_EDP_HPD_1V8 GPIO(GPIO17) #define GPIO_EN_PP3300_EDP_DISP_X GPIO(DSI1_LCM_RST) -#define GPIO_MIPI_PANEL_BL_PWM GPIO(DISP_PWM0) +#define GPIO_MIPI_BL_PWM_1V8 GPIO(DISP_PWM0) void setup_chromeos_gpios(void); diff --git a/src/mainboard/google/geralt/panel_geralt.c b/src/mainboard/google/geralt/panel_geralt.c index dfcd721fd3..33e1540a87 100644 --- a/src/mainboard/google/geralt/panel_geralt.c +++ b/src/mainboard/google/geralt/panel_geralt.c @@ -12,7 +12,7 @@ static void configure_mipi_pwm_backlight(void) { gpio_output(GPIO_AP_DISP_BKLTEN, 0); - gpio_output(GPIO_MIPI_PANEL_BL_PWM, 0); + gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); } static void configure_edp_aux_backlight(void) @@ -62,7 +62,7 @@ void fill_lp_backlight_gpios(struct lb_gpios *gpios) return; struct lb_gpio mipi_pwm_gpios[] = { - {GPIO_MIPI_PANEL_BL_PWM.id, ACTIVE_HIGH, -1, "PWM control"}, + {GPIO_MIPI_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, }; struct lb_gpio edp_pwm_gpios[] = {