From 26e59a62809d5f0f8d5f4469441490544506978d Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sat, 8 Jun 2019 19:49:48 +0200 Subject: [PATCH] sb/intel/common/fw: Make make aware that it needs binaries As we redirect all `dd` output to /dev/null (it would clutter the console otherwise), there is no error message if a binary to be added isn't found. If we add them as dependency, OTOH, `make` will complain properly. Change-Id: I40c3979b84341cb88c7e9a5084c1a97230ea5503 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/33327 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/southbridge/intel/common/firmware/Makefile.inc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc index 898ab60770..e7060361bd 100644 --- a/src/southbridge/intel/common/firmware/Makefile.inc +++ b/src/southbridge/intel/common/firmware/Makefile.inc @@ -31,6 +31,16 @@ ifneq ($(call strip_quotes,$(CONFIG_IFD_CHIPSET)),) IFDTOOL_USE_CHIPSET := -p $(CONFIG_IFD_CHIPSET) endif +add_intel_firmware: $(call strip_quotes,$(CONFIG_IFD_BIN_PATH)) +ifeq ($(CONFIG_HAVE_ME_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_ME_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_GBE_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_GBE_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_EC_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH)) +endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) printf " DD Adding Intel Firmware Descriptor\n" dd if=$(IFD_BIN_PATH) \