GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: Avoid NULL pointer deference 

Coverity detects dereference pointers req and res that are NULL when
calling the pmc_send_ipc_cmd function. This change prevents NULL
pointers dereference.

Found-by: Coverity CID 1458077, 1458078
TEST=None

Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: I151157e7a9a90c43075f431933ac44f29fd25127
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56123
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
John Zhao 2021-07-06 10:28:18 -07:00 committed by Felix Held
parent f96aa7a687
commit 270e25594f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/intel/alderlake/crashlog.c
View File

@ -32,8 +32,8 @@ bool pmc_cl_discovery(void)
{
u32 tmp_bar_addr = 0, desc_table_addr = 0;
const struct pmc_ipc_buffer *req = { 0 };
struct pmc_ipc_buffer *res = NULL;
const struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer res;
uint32_t cmd_reg;
int r;
@ -42,13 +42,13 @@ bool pmc_cl_discovery(void)
PMC_IPC_CMD_SIZE_SHIFT);
printk(BIOS_DEBUG, "cmd_reg from pmc_make_ipc_cmd %d\n", cmd_reg);
r = pmc_send_ipc_cmd(cmd_reg, req, res);
r = pmc_send_ipc_cmd(cmd_reg, &req, &res);
if (r < 0) {
printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__);
return false;
}
discovery_buf.val_64_bits = ((u64)res->buf[1] << 32) | res->buf[0];
discovery_buf.val_64_bits = ((u64)res.buf[1] << 32) | res.buf[0];
if (discovery_buf.bits.supported != 1) {