GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/hatch: update ACPI HID/CID for Synaptics touchpads 

The currently assigned ACPI HID 'PNP0C50' is not a valid per Windows
WHQL validation tests. To ensure compatibility with both Windows and
Linux, set the HID to 'SYNA0000' and CID to 'ACPI0C50' as previously
done for other boards (eg, google/lulu).

TEST=boot Linux 5.1x, Windows 10 on bobba, verify all touchpad
functions work correctly.

Change-Id: I4fd66be21eeff5f37b58a8922c49683a28685064
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71074
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2022-12-19 15:15:52 -06:00 committed by Martin L Roth
parent f39e105deb
commit 2793716910
6 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/octopus/variants/bobba/overridetree.cb
View File

@ -175,7 +175,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"

3
src/mainboard/google/octopus/variants/dood/overridetree.cb
View File

@ -110,7 +110,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"

3
src/mainboard/google/octopus/variants/foob/overridetree.cb
View File

@ -124,7 +124,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"

3
src/mainboard/google/octopus/variants/garg/overridetree.cb
View File

@ -152,7 +152,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"

3
src/mainboard/google/octopus/variants/lick/overridetree.cb
View File

@ -102,7 +102,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"

3
src/mainboard/google/octopus/variants/phaser/overridetree.cb
View File

@ -138,7 +138,8 @@ chip soc/intel/apollolake
device i2c 15 on end device i2c 15 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""SYNA0000""
register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "generic.wake" = "GPE0_DW3_27" register "generic.wake" = "GPE0_DW3_27"