From 279afdc24b3c65275cad222be53b908bb0f752ef Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Fri, 1 Feb 2019 12:32:51 +0100 Subject: [PATCH] intel/apollolake: Add parameter to enable VTD in devicetree The FSP has a parameter to enable or disable the VTD feature (Intel's Virtualization Technology for Directed I/O). In current header files for FSP-S (Apollo Lake and Gemini Lake) this parameter is set to disabled per default. Therefore, if the FSP was not modified via BCT, this feature is most likely disabled on all mainboards. Add a chip parameter so that VTD can be enabled on mainboard level in devicetree and therefore this feature can be activated if needed. Change-Id: Ic0bfcf1719e1ccc678a932bf3d38c6dbce3556bc Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/31194 Reviewed-by: Furquan Shaikh Reviewed-by: Nico Huber Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/chip.c | 3 +++ src/soc/intel/apollolake/chip.h | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index de33e8217b..363450911a 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -754,6 +754,9 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd) if (!xdci_can_enable()) dev->enabled = 0; silconfig->UsbOtg = dev->enabled; + + /* Set VTD feature according to devicetree */ + silconfig->VtdEnable = cfg->enable_vtd; } struct chip_operations soc_intel_apollolake_ops = { diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 6c2404a405..b9e368cddc 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -188,6 +188,12 @@ struct soc_intel_apollolake_config { * 00=1.10v, 01=1.15v, 10=1.24v, 11=1.20v (default). */ uint32_t PmicVdd2Voltage; + + /* Option to enable VTD feature. Default is 0 which disables VTD + * capability in FSP. Setting this option to 1 in devicetree will enable + * the Upd parameter VtdEnable. + */ + uint8_t enable_vtd; }; typedef struct soc_intel_apollolake_config config_t;