GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/prodrive/hermes: Limit amount of data copied into struct 

Change strcpy to strncpy just to be safe.

Found-by: Coverity Scan #1446759
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I7ed094a313692806a6ab6b4226b9978647e9cb8d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78621
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Martin Roth 2023-10-23 19:47:32 -06:00 committed by Martin L Roth
parent 4bae323746
commit 27b4a60baf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/prodrive/hermes/mainboard.c
View File

@ -111,7 +111,7 @@ static void update_board_layout(void)
continue; continue;
layout.cpu_count++; layout.cpu_count++;
if (!layout.cpu_name[0]) if (!layout.cpu_name[0])
strcpy(layout.cpu_name, cpu->name); strncpy(layout.cpu_name, cpu->name, sizeof(layout.cpu_name));
} }
if (cpuid_get_max_func() >= 0x16) if (cpuid_get_max_func() >= 0x16)