GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/hp/kbc1126: Support not putting EC firmware in CBFS 

For mainboards using the HP KBC1126 EC interface, but with a different
EC implementation, we don't put the EC firmware in the CBFS image. Add
a Kconfig option to prevent the build system warning on not inserting
the EC firmware.

After this change, building coreboot for EliteBook Folio 9480m will
not have a warning on not inserting the EC firmware.

The build system still builds a working coreboot image for EliteBook
2560p, and gives a warning if not choosing to insert the EC firmware.

Change-Id: I3be83a13d138d3623064ef2803f3e3a340207ead
Signed-off-by: Iru Cai <mytbk920423@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45575
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Iru Cai 2020-09-16 21:10:58 +08:00 committed by Patrick Georgi
parent 90381231ea
commit 27dc761d08
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ec/hp/kbc1126/Kconfig
View File

@ -5,7 +5,12 @@ config EC_HP_KBC1126
help help
Interface to SMSC KBC1126 embedded controller in HP laptops. Interface to SMSC KBC1126 embedded controller in HP laptops.
if EC_HP_KBC1126 config EC_HP_KBC1126_ECFW_IN_CBFS
bool
depends on EC_HP_KBC1126
default y
if EC_HP_KBC1126_ECFW_IN_CBFS
comment "Please select the following otherwise your laptop cannot be powered on." comment "Please select the following otherwise your laptop cannot be powered on."

10
src/ec/hp/kbc1126/Makefile.inc
View File

@ -1,6 +1,6 @@
## SPDX-License-Identifier: GPL-2.0-only ## SPDX-License-Identifier: GPL-2.0-only
ifeq ($(CONFIG_EC_HP_KBC1126),y) ifeq ($(CONFIG_EC_HP_KBC1126_ECFW_IN_CBFS),y)
KBC1126_EC_INSERT:=$(top)/util/kbc1126/kbc1126_ec_insert KBC1126_EC_INSERT:=$(top)/util/kbc1126/kbc1126_ec_insert
INTERMEDIATE+=kbc1126_ec_insert INTERMEDIATE+=kbc1126_ec_insert
@ -39,8 +39,8 @@ ifeq ($(CONFIG_KBC1126_FIRMWARE),)
printf "You can read util/kbc1126/README.md for details.\n\n" printf "You can read util/kbc1126/README.md for details.\n\n"
endif endif
ramstage-y += ec.c
bootblock-y += early_init.c
romstage-y += early_init.c
endif endif
ramstage-$(CONFIG_EC_HP_KBC1126) += ec.c
bootblock-$(CONFIG_EC_HP_KBC1126) += early_init.c
romstage-$(CONFIG_EC_HP_KBC1126) += early_init.c