GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge: DEVICE_NOOP some stub function callbacks 

Reduces loc and makes NOP's explicit.

Change-Id: I8a117b150b8b421c7a18b48a2ac36d15679f20b0
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7344
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Edward O'Callaghan 2014-11-06 08:57:40 +11:00
parent 5ad6ec55f8
commit 2837ab2cdf
4 changed files with 9 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/northbridge/amd/agesa/family14/northbridge.c
View File

@ -779,15 +779,7 @@ static void domain_enable_resources(device_t dev)
/* Bus related code */ /* Bus related code */
static void cpu_bus_read_resources(device_t dev) static u32 cpu_bus_scan(struct device *dev, u32 max)
{
}
static void cpu_bus_set_resources(device_t dev)
{
}
static u32 cpu_bus_scan(device_t dev, u32 max)
{ {
struct bus *cpu_bus = dev->link_list; struct bus *cpu_bus = dev->link_list;
device_t cpu; device_t cpu;
@ -846,8 +838,8 @@ static struct device_operations pci_domain_ops = {
}; };
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = NULL, .enable_resources = NULL,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

12
src/northbridge/amd/agesa/family15/northbridge.c
View File

@ -1092,17 +1092,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

12
src/northbridge/amd/agesa/family15tn/northbridge.c
View File

@ -1054,17 +1054,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

8
src/northbridge/amd/amdfam10/northbridge.c
View File

@ -1411,11 +1411,7 @@ static void cpu_bus_init(device_t dev)
#endif #endif
} }
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_set_resources(struct device *dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{ {
struct resource *resource = find_resource(dev, 0xc0010058); struct resource *resource = find_resource(dev, 0xc0010058);
if (resource) { if (resource) {
@ -1425,7 +1421,7 @@ static void cpu_bus_set_resources(device_t dev)
} }
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,