GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AGESA: Add "const" modifier to function parameters 

Add CONST modifiers to read-only pass-by-reference function
parameters in AGESA.  This allows the use of "const" modifiers
on the declaration of lookup tables that are pass-by-reference.
These will be used to identify tables that are copied onto the
HEAP but don't need to be.

Change-Id: Ie1187a427804fddf47b935a110ad23931a3447a9
Signed-off-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Reviewed-on: http://review.coreboot.org/3393
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Bruce Griffith 2013-06-04 14:16:24 -06:00 committed by Stefan Reinauer
parent aa588e0273
commit 283ba78415
6 changed files with 64 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/vendorcode/amd/agesa/f15tn/AGESA.h
View File

@ -976,8 +976,8 @@ typedef struct {
* @li @b Bit31 - last descriptor in topology * @li @b Bit31 - last descriptor in topology
*/ */
IN UINT32 SocketId; ///< Socket Id IN UINT32 SocketId; ///< Socket Id
IN PCIe_PORT_DESCRIPTOR *PciePortList; ///< Pointer to array of PCIe port descriptors or NULL (Last element of array must be terminated with DESCRIPTOR_TERMINATE_LIST). IN CONST PCIe_PORT_DESCRIPTOR *PciePortList; ///< Pointer to array of PCIe port descriptors or NULL (Last element of array must be terminated with DESCRIPTOR_TERMINATE_LIST).
IN PCIe_DDI_DESCRIPTOR *DdiLinkList; ///< Pointer to array DDI link descriptors (Last element of array must be terminated with DESCRIPTOR_TERMINATE_LIST). IN CONST PCIe_DDI_DESCRIPTOR *DdiLinkList; ///< Pointer to array DDI link descriptors (Last element of array must be terminated with DESCRIPTOR_TERMINATE_LIST).
IN VOID *Reserved; ///< Reserved for future use IN VOID *Reserved; ///< Reserved for future use
} PCIe_COMPLEX_DESCRIPTOR; } PCIe_COMPLEX_DESCRIPTOR;

2
src/vendorcode/amd/agesa/f15tn/Legacy/Proc/Dispatcher.c
View File

@ -111,7 +111,7 @@ AmdAgesaDispatcher (
DISPATCH_TABLE *Entry; DISPATCH_TABLE *Entry;
UINT32 ImageStart; UINT32 ImageStart;
UINT32 ImageEnd; UINT32 ImageEnd;
AMD_IMAGE_HEADER* AltImagePtr; CONST AMD_IMAGE_HEADER* AltImagePtr;
Status = AGESA_UNSUPPORTED; Status = AGESA_UNSUPPORTED;
ImageEntry = NULL; ImageEntry = NULL;

60
src/vendorcode/amd/agesa/f15tn/Lib/amdlib.c
View File

@ -111,8 +111,8 @@ VOID
STATIC STATIC
LibAmdGetDataFromPtr ( LibAmdGetDataFromPtr (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
OUT UINT32 *TemData, OUT UINT32 *TemData,
OUT UINT32 *TempDataMask OUT UINT32 *TempDataMask
); );
@ -549,7 +549,7 @@ VOID
LibAmdIoWrite ( LibAmdIoWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -587,8 +587,8 @@ VOID
LibAmdIoRMW ( LibAmdIoRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -619,8 +619,8 @@ VOID
LibAmdIoPoll ( LibAmdIoPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
@ -686,7 +686,7 @@ VOID
LibAmdMemWrite ( LibAmdMemWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -724,8 +724,8 @@ VOID
LibAmdMemRMW ( LibAmdMemRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -756,8 +756,8 @@ VOID
LibAmdMemPoll ( LibAmdMemPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
@ -837,7 +837,7 @@ VOID
LibAmdPciWrite ( LibAmdPciWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -893,8 +893,8 @@ VOID
LibAmdPciRMW ( LibAmdPciRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -925,8 +925,8 @@ VOID
LibAmdPciPoll ( LibAmdPciPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
@ -1025,7 +1025,7 @@ LibAmdPciWriteBits (
IN PCI_ADDR Address, IN PCI_ADDR Address,
IN UINT8 Highbit, IN UINT8 Highbit,
IN UINT8 Lowbit, IN UINT8 Lowbit,
IN UINT32 *Value, IN CONST UINT32 *Value,
IN AMD_CONFIG_PARAMS *StdHeader IN AMD_CONFIG_PARAMS *StdHeader
) )
{ {
@ -1161,13 +1161,13 @@ LibAmdMemFill (
VOID VOID
LibAmdMemCopy ( LibAmdMemCopy (
IN VOID *Destination, IN VOID *Destination,
IN VOID *Source, IN CONST VOID *Source,
IN UINTN CopyLength, IN UINTN CopyLength,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
) )
{ {
UINT8 *Dest; UINT8 *Dest;
UINT8 *SourcePtr; CONST UINT8 *SourcePtr;
ASSERT (StdHeader != NULL); ASSERT (StdHeader != NULL);
Dest = Destination; Dest = Destination;
SourcePtr = Source; SourcePtr = Source;
@ -1187,7 +1187,7 @@ LibAmdMemCopy (
*/ */
BOOLEAN BOOLEAN
LibAmdVerifyImageChecksum ( LibAmdVerifyImageChecksum (
IN VOID *ImagePtr IN CONST VOID *ImagePtr
) )
{ {
// Assume ImagePtr points to the binary start ($AMD) // Assume ImagePtr points to the binary start ($AMD)
@ -1224,19 +1224,19 @@ LibAmdVerifyImageChecksum (
* @retval NULL if image not found * @retval NULL if image not found
* @retval pointer to image header * @retval pointer to image header
*/ */
VOID * CONST VOID *
LibAmdLocateImage ( LibAmdLocateImage (
IN VOID *StartAddress, IN CONST VOID *StartAddress,
IN VOID *EndAddress, IN CONST VOID *EndAddress,
IN UINT32 Alignment, IN UINT32 Alignment,
IN CHAR8 ModuleSignature[8] IN CONST CHAR8 ModuleSignature[8]
) )
{ {
UINT8 *CurrentPtr; CONST UINT8 *CurrentPtr;
AMD_MODULE_HEADER *ModuleHeaderPtr; AMD_MODULE_HEADER *ModuleHeaderPtr;
UINT64 *SearchStr; CONST UINT64 *SearchStr;
UINT64 *InputStr; CONST UINT64 *InputStr;
CurrentPtr = StartAddress; CurrentPtr = StartAddress;
InputStr = (UINT64 *)ModuleSignature; InputStr = (UINT64 *)ModuleSignature;
@ -1300,8 +1300,8 @@ VOID
STATIC STATIC
LibAmdGetDataFromPtr ( LibAmdGetDataFromPtr (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
OUT UINT32 *TemData, OUT UINT32 *TemData,
OUT UINT32 *TempDataMask OUT UINT32 *TempDataMask
) )

44
src/vendorcode/amd/agesa/f15tn/Lib/amdlib.h
View File

@ -182,7 +182,7 @@ VOID
LibAmdIoWrite ( LibAmdIoWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -190,8 +190,8 @@ VOID
LibAmdIoRMW ( LibAmdIoRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -199,8 +199,8 @@ VOID
LibAmdIoPoll ( LibAmdIoPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT16 IoAddress, IN UINT16 IoAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -218,7 +218,7 @@ VOID
LibAmdMemWrite ( LibAmdMemWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -226,8 +226,8 @@ VOID
LibAmdMemRMW ( LibAmdMemRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -235,8 +235,8 @@ VOID
LibAmdMemPoll ( LibAmdMemPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN UINT64 MemAddress, IN UINT64 MemAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -254,7 +254,7 @@ VOID
LibAmdPciWrite ( LibAmdPciWrite (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Value, IN CONST VOID *Value,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -262,8 +262,8 @@ VOID
LibAmdPciRMW ( LibAmdPciRMW (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -271,8 +271,8 @@ VOID
LibAmdPciPoll ( LibAmdPciPoll (
IN ACCESS_WIDTH AccessWidth, IN ACCESS_WIDTH AccessWidth,
IN PCI_ADDR PciAddress, IN PCI_ADDR PciAddress,
IN VOID *Data, IN CONST VOID *Data,
IN VOID *DataMask, IN CONST VOID *DataMask,
IN UINT64 Delay, IN UINT64 Delay,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
@ -291,7 +291,7 @@ LibAmdPciWriteBits (
IN PCI_ADDR Address, IN PCI_ADDR Address,
IN UINT8 Highbit, IN UINT8 Highbit,
IN UINT8 Lowbit, IN UINT8 Lowbit,
IN UINT32 *Value, IN CONST UINT32 *Value,
IN AMD_CONFIG_PARAMS *StdHeader IN AMD_CONFIG_PARAMS *StdHeader
); );
@ -321,17 +321,17 @@ LibAmdMemFill (
VOID VOID
LibAmdMemCopy ( LibAmdMemCopy (
IN VOID *Destination, IN VOID *Destination,
IN VOID *Source, IN CONST VOID *Source,
IN UINTN CopyLength, IN UINTN CopyLength,
IN OUT AMD_CONFIG_PARAMS *StdHeader IN OUT AMD_CONFIG_PARAMS *StdHeader
); );
VOID * CONST VOID *
LibAmdLocateImage ( LibAmdLocateImage (
IN VOID *StartAddress, IN CONST VOID *StartAddress,
IN VOID *EndAddress, IN CONST VOID *EndAddress,
IN UINT32 Alignment, IN UINT32 Alignment,
IN CHAR8 ModuleSignature[8] IN CONST CHAR8 ModuleSignature[8]
); );
UINT32 UINT32
@ -341,7 +341,7 @@ LibAmdGetPackageType (
BOOLEAN BOOLEAN
LibAmdVerifyImageChecksum ( LibAmdVerifyImageChecksum (
IN VOID *ImagePtr IN CONST VOID *ImagePtr
); );
UINT8 UINT8

12
src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbPcieConfig/PcieInputParser.c
View File

@ -113,7 +113,7 @@
*/ */
UINTN UINTN
PcieInputParserGetNumberOfComplexes ( PcieInputParserGetNumberOfComplexes (
IN PCIe_COMPLEX_DESCRIPTOR *ComplexList IN CONST PCIe_COMPLEX_DESCRIPTOR *ComplexList
) )
{ {
UINTN Result; UINTN Result;
@ -136,11 +136,11 @@ PcieInputParserGetNumberOfComplexes (
*/ */
UINTN UINTN
PcieInputParserGetLengthOfPcieEnginesList ( PcieInputParserGetLengthOfPcieEnginesList (
IN PCIe_COMPLEX_DESCRIPTOR *Complex IN CONST PCIe_COMPLEX_DESCRIPTOR *Complex
) )
{ {
UINTN Result; UINTN Result;
PCIe_PORT_DESCRIPTOR *PciePortList; CONST PCIe_PORT_DESCRIPTOR *PciePortList;
Result = 0; Result = 0;
PciePortList = Complex->PciePortList; PciePortList = Complex->PciePortList;
while (PciePortList != NULL) { while (PciePortList != NULL) {
@ -161,11 +161,11 @@ PcieInputParserGetLengthOfPcieEnginesList (
*/ */
STATIC UINTN STATIC UINTN
PcieInputParserGetLengthOfDdiEnginesList ( PcieInputParserGetLengthOfDdiEnginesList (
IN PCIe_COMPLEX_DESCRIPTOR *Complex IN CONST PCIe_COMPLEX_DESCRIPTOR *Complex
) )
{ {
UINTN Result; UINTN Result;
PCIe_DDI_DESCRIPTOR *DdiLinkList; CONST PCIe_DDI_DESCRIPTOR *DdiLinkList;
Result = 0; Result = 0;
DdiLinkList = Complex->DdiLinkList; DdiLinkList = Complex->DdiLinkList;
while (DdiLinkList != NULL) { while (DdiLinkList != NULL) {
@ -187,7 +187,7 @@ PcieInputParserGetLengthOfDdiEnginesList (
*/ */
UINTN UINTN
PcieInputParserGetNumberOfEngines ( PcieInputParserGetNumberOfEngines (
IN PCIe_COMPLEX_DESCRIPTOR *Complex IN CONST PCIe_COMPLEX_DESCRIPTOR *Complex
) )
{ {
UINTN Result; UINTN Result;

6
src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbPcieConfig/PcieInputParser.h
View File

@ -75,12 +75,12 @@
UINTN UINTN
PcieInputParserGetNumberOfComplexes ( PcieInputParserGetNumberOfComplexes (
IN PCIe_COMPLEX_DESCRIPTOR *ComplexList IN CONST PCIe_COMPLEX_DESCRIPTOR *ComplexList
); );
UINTN UINTN
PcieInputParserGetNumberOfEngines ( PcieInputParserGetNumberOfEngines (
IN PCIe_COMPLEX_DESCRIPTOR *Complex IN CONST PCIe_COMPLEX_DESCRIPTOR *Complex
); );
@ -104,7 +104,7 @@ PcieInputParserGetComplexDescriptorOfSocket (
UINTN UINTN
PcieInputParserGetLengthOfPcieEnginesList ( PcieInputParserGetLengthOfPcieEnginesList (
IN PCIe_COMPLEX_DESCRIPTOR *Complex IN CONST PCIe_COMPLEX_DESCRIPTOR *Complex
); );
#endif #endif