GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/pc80/rtc: Swap cmos_write32() parameter order 

Make it consistent with the more used cmos_write().

Change-Id: I9cf643c770e9819de08dbede48b73f3d4fe15bd7
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38178
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2020-01-04 12:58:53 +02:00
parent 19be7b569e
commit 287910765d
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/console/post.c
View File

@ -98,8 +98,8 @@ void cmos_post_init(void)
cmos_write(0, CMOS_POST_BANK_0_OFFSET); cmos_write(0, CMOS_POST_BANK_0_OFFSET);
cmos_write(0, CMOS_POST_BANK_1_OFFSET); cmos_write(0, CMOS_POST_BANK_1_OFFSET);
#if CONFIG(CMOS_POST_EXTRA) #if CONFIG(CMOS_POST_EXTRA)
cmos_write32(CMOS_POST_BANK_0_EXTRA, 0); cmos_write32(0, CMOS_POST_BANK_0_EXTRA);
cmos_write32(CMOS_POST_BANK_1_EXTRA, 0); cmos_write32(0, CMOS_POST_BANK_1_EXTRA);
#endif #endif
} }
@ -113,10 +113,10 @@ void post_log_extra(u32 value)
switch (cmos_read(CMOS_POST_BANK_OFFSET)) { switch (cmos_read(CMOS_POST_BANK_OFFSET)) {
case CMOS_POST_BANK_0_MAGIC: case CMOS_POST_BANK_0_MAGIC:
cmos_write32(CMOS_POST_BANK_0_EXTRA, value); cmos_write32(value, CMOS_POST_BANK_0_EXTRA);
break; break;
case CMOS_POST_BANK_1_MAGIC: case CMOS_POST_BANK_1_MAGIC:
cmos_write32(CMOS_POST_BANK_1_EXTRA, value); cmos_write32(value, CMOS_POST_BANK_1_EXTRA);
break; break;
} }

2
src/include/pc80/mc146818rtc.h
View File

@ -171,7 +171,7 @@ static inline u32 cmos_read32(u8 offset)
return value; return value;
} }
static inline void cmos_write32(u8 offset, u32 value) static inline void cmos_write32(u32 value, u8 offset)
{ {
u8 i; u8 i;
for (i = 0; i < sizeof(value); ++i) for (i = 0; i < sizeof(value); ++i)

4
src/northbridge/intel/sandybridge/raminit_mrc.c
View File

@ -66,11 +66,11 @@ void save_mrc_data(struct pei_data *pei_data)
pei_data->mrc_output_len); pei_data->mrc_output_len);
/* Save the MRC seed values to CMOS */ /* Save the MRC seed values to CMOS */
cmos_write32(CMOS_OFFSET_MRC_SEED, pei_data->scrambler_seed); cmos_write32(pei_data->scrambler_seed, CMOS_OFFSET_MRC_SEED);
printk(BIOS_DEBUG, "Save scrambler seed 0x%08x to CMOS 0x%02x\n", printk(BIOS_DEBUG, "Save scrambler seed 0x%08x to CMOS 0x%02x\n",
pei_data->scrambler_seed, CMOS_OFFSET_MRC_SEED); pei_data->scrambler_seed, CMOS_OFFSET_MRC_SEED);
cmos_write32(CMOS_OFFSET_MRC_SEED_S3, pei_data->scrambler_seed_s3); cmos_write32(pei_data->scrambler_seed_s3, CMOS_OFFSET_MRC_SEED_S3);
printk(BIOS_DEBUG, "Save s3 scrambler seed 0x%08x to CMOS 0x%02x\n", printk(BIOS_DEBUG, "Save s3 scrambler seed 0x%08x to CMOS 0x%02x\n",
pei_data->scrambler_seed_s3, CMOS_OFFSET_MRC_SEED_S3); pei_data->scrambler_seed_s3, CMOS_OFFSET_MRC_SEED_S3);