GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tpm: Correct TI50_FIRMWARE_VERSION_NOT_SUPPORTED help text 

Reading firmware_version register is supported on Ti50 version
0.22.4. Therefore correct the help text of the Kconfig option
TI50_FIRMWARE_VERSION_NOT_SUPPORTED.

Also change the message level to BIOS_WARNING.

BUG=b:234533588
TEST=emerge-corsola coreboot
BRANCH=none

Change-Id: I66a0ef896c9dc4cd0f586555a55dbcd1cfd863f9
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66906
Reviewed-by: Yidi Lin <yidilin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Andrey Pronin <apronin@google.com>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
This commit is contained in:
Yu-Ping Wu 2022-08-19 11:59:55 +08:00 committed by Martin L Roth
parent 6aec7c57b2
commit 28f1729f15
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/drivers/tpm/cr50.c
View File

@ -193,7 +193,7 @@ enum cb_err cr50_get_firmware_version(struct cr50_firmware_version *version)
goto success; goto success;
if (CONFIG(TI50_FIRMWARE_VERSION_NOT_SUPPORTED)) { if (CONFIG(TI50_FIRMWARE_VERSION_NOT_SUPPORTED)) {
printk(BIOS_ERR, "Reading Ti50 firmware version is not supported\n"); printk(BIOS_WARNING, "Reading Ti50 firmware version is not supported\n");
if (version) if (version)
*version = cr50_firmware_version; *version = cr50_firmware_version;
return CB_ERR; return CB_ERR;

6
src/security/tpm/tss/vendor/cr50/Kconfig vendored
View File

@ -34,11 +34,11 @@ config TI50_FIRMWARE_VERSION_NOT_SUPPORTED
bool bool
default n default n
help help
Ti50 FW versions below 0.15 don't support the firmware_version register, Ti50 FW versions below 0.22.4 don't support the firmware_version register,
and trying to access it causes I2C errors. This config will skip accesses and trying to access it causes I2C errors. This config will skip accesses
to the register, and should be selected for boards using Ti50 chips with to the register, and should be selected for boards using Ti50 chips with
FW < 0.0.15. The config will be removed once all Ti50 stocks are updated to FW < 0.22.4. The config will be removed once all Ti50 stocks are updated to
0.0.15 or higher. 0.22.4 or higher.
config GOOGLE_TPM_IRQ_TIMEOUT_MS config GOOGLE_TPM_IRQ_TIMEOUT_MS
int int