IASL: Ignore IASL's "Missing dependency" warning

IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
 1) If _PRS is present, must have _CRS and _SRS
 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS)
 4) If _SRS is present, probably should have a _DIS (Remark only)
IASL will issue a warning for each missing dependency.
Ignore this warnings for existing ASL code and issue a message when the build is complete.

Change-Id: I28b437194f08232727623009372327fec15215dd
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59880
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Martin Roth <martinroth@google.com>

Makefile.inc

@@ -263,9 +263,26 @@ EMPTY_RESOURCE_TEMPLATE_WARNING = 3150
 # Redundant offset remarks are not useful in any way and are masking useful
 # ones that might indicate an issue so it is better to hide them.
 REDUNDANT_OFFSET_REMARK = 2158
+# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
+#	1) If _PRS is present, must have _CRS and _SRS
+#	2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
+#	3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS)
+#	4) If _SRS is present, probably should have a _DIS (Remark only)
+# A warning will be issued for each of these cases.
+# For existing ASL code, ignore this warnings
+IASL_MISSING_DEPENDENCY = 3141
 
 IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK)
 
+ifeq ($(CONFIG_IGNORE_IASL_MISSING_DEPENDENCY),y)
+	IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY)
+build_complete::
+	printf "*** WARNING: The ASL code for this platform is incomplete.  Please fix it. ***\n"
+	printf "*** If _PRS is present, must have _CRS and _SRS ***\n"
+	printf "*** If _SRS is present, must have _PRS, _CRS, and _SRS ***\n"
+	printf "*** If _DIS is present, must have _SRS, _PRS, _CRS, and _SRS ***\n"
+endif
+
 IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST))
 
 define asl_template

src/mainboard/acer/g43t-am3/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_ACER_G43T_AM3
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_LGA775

src/mainboard/asrock/h81m-hds/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_ASROCK_H81M_HDS
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_4096

src/mainboard/asus/am1i-a/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_ASUS_AM1I_A
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/asus/h61-series/Kconfig

@@ -1,5 +1,8 @@
 ## SPDX-License-Identifier: GPL-2.0-only
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_ASUS_H61_SERIES
 	bool
 	select HAVE_ACPI_RESUME

src/mainboard/asus/p5qpl-am/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_ASUS_P5QPL_AM || BOARD_ASUS_P5G41T_M_LX
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_LGA775

src/mainboard/bap/ode_e20XX/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_ODE_E20XX
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_AMD_AGESA_FAMILY16_KB

src/mainboard/biostar/am1ml/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_BIOSTAR_AM1ML
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_4096

src/mainboard/dell/optiplex_9010/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_DELL_OPTIPLEX_9010
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_12288

src/mainboard/facebook/fbg1701/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_FACEBOOK_FBG1701
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/facebook/monolith/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_FACEBOOK_MONOLITH
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/foxconn/d41s/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_FOXCONN_D41S
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_FCBGA559

src/mainboard/foxconn/g41s-k/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_FOXCONN_G41S_K || BOARD_FOXCONN_G41M
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_LGA775

src/mainboard/gigabyte/ga-d510ud/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_GIGABYTE_GA_D510UD
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_512

src/mainboard/google/auron/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_AURON
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/beltino/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_BELTINO
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/brya/Kconfig

@@ -1,3 +1,6 @@
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BRYA_COMMON
 	def_bool n
 	select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR

src/mainboard/google/butterfly/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_GOOGLE_BUTTERFLY
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/cyan/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_CYAN
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/dedede/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_DEDEDE
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768

src/mainboard/google/deltaur/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_DELTAUR
 	def_bool n
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/google/drallion/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_DRALLION
 	def_bool n
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/google/eve/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_GOOGLE_EVE
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/fizz/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_FIZZ
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/glados/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_GLADOS
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/guybrush/Kconfig

@@ -1,5 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_GUYBRUSH
 	def_bool n
 

src/mainboard/google/hatch/Kconfig

@@ -1,3 +1,5 @@
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
 
 config BOARD_GOOGLE_HATCH_COMMON
 	def_bool n

src/mainboard/google/jecht/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_JECHT
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/kahlee/Kconfig

@@ -1,5 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_KAHLEE
 	bool
 	select SOC_AMD_STONEYRIDGE

src/mainboard/google/link/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_GOOGLE_LINK
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/octopus/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/poppy/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_POPPY
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/rambi/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_RAMBI
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/reef/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_REEF
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/google/sarien/Kconfig

@@ -1,3 +1,6 @@
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_SARIEN
 	def_bool n
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/google/slippy/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_SLIPPY
 	def_bool n
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/stout/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_GOOGLE_STOUT
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/google/volteer/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_VOLTEER
 	def_bool n
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/google/zork/Kconfig

@@ -1,5 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_GOOGLE_BASEBOARD_TREMBYLE
 	def_bool n
 

src/mainboard/ibase/mb899/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_IBASE_MB899
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_M

src/mainboard/intel/adlrvp/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_INTEL_ADLRVP_COMMON
 	def_bool n
 	select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR

src/mainboard/intel/baskingridge/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_BASKING_RIDGE
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select NORTHBRIDGE_INTEL_HASWELL

src/mainboard/intel/dcp847ske/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_DCP847SKE
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/intel/dg41wv/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_INTEL_DG41WV
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_LGA775

src/mainboard/intel/dg43gt/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_INTEL_DG43GT
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_LGA775

src/mainboard/intel/emeraldlake2/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_EMERALDLAKE2
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select NORTHBRIDGE_INTEL_SANDYBRIDGE

src/mainboard/intel/glkrvp/Kconfig

@@ -1,4 +1,7 @@
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_INTEL_BASEBOARD_GLKRVP
 	def_bool n
 	select SOC_INTEL_GEMINILAKE

src/mainboard/intel/jasperlake_rvp/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_INTEL_JASPERLAKE_RVP_COMMON
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/intel/kblrvp/Kconfig

@@ -1,3 +1,7 @@
+
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_INTEL_KBLRVP_COMMON
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/intel/kunimitsu/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_KUNIMITSU
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/intel/shadowmountain/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_SHADOWMOUNTAIN
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/intel/strago/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_STRAGO
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/intel/tglrvp/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_INTEL_TGLRVP_UP3 || BOARD_INTEL_TGLRVP_UP4
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_32768

src/mainboard/kontron/986lcd-m/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_KONTRON_986LCD_M
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select CPU_INTEL_SOCKET_M

src/mainboard/portwell/m107/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_PORTWELL_M107
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/protectli/vault_bsw/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_PROTECTLI_FW2B || BOARD_PROTECTLI_FW4B
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/samsung/lumpy/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_SAMSUNG_LUMPY
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select SYSTEM_TYPE_LAPTOP

src/mainboard/samsung/stumpy/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_SAMSUNG_STUMPY
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192

src/mainboard/supermicro/x10slm-f/Kconfig

@@ -2,6 +2,9 @@
 
 if BOARD_SUPERMICRO_X10SLM_PLUS_F
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384

src/mainboard/supermicro/x9scl/Kconfig

@@ -1,5 +1,8 @@
 if BOARD_SUPERMICRO_X9SCL
 
+config IGNORE_IASL_MISSING_DEPENDENCY
+	def_bool y
+
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192