soc/amd/stoneyridge: Add ACPI D3Cold support for SD Controller

We need to support entering D3Cold from the OS to work around a bug in
the SDHC where the data lines get stuck always reading zeros.

BUG=b:122749418
TEST=Verified the linux kernel can transition between D3 and D0. Also
verified that the device can suspend and resume and continue to have a
functioning SD controller after.

Change-Id: Ifbf48f20c03a752ce3ff773296b536e92db16a62
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32433
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Raul E Rangel 2019-04-23 16:02:15 -06:00 committed by Martin Roth
parent cd51d7ced5
commit 29150c83df
1 changed files with 28 additions and 3 deletions

View File

@ -56,6 +56,16 @@ Device(SBUS) {
/* 0:14.7 - SD Controller */
Device(SDCN) {
Name(_ADR, 0x00140007)
Method(_PS0) {
FDDC(24, 0)
}
Method(_PS3) {
FDDC(24, 3)
}
Method(_PSC) {
Return(SDTD)
}
} /* end SDCN */
Name(CRES, ResourceTemplate() {
@ -286,8 +296,9 @@ Field( SMIC, ByteAcc, NoLock, Preserve) {
offset (0x1e70), /* SD D3 Control */
SDTD, 2,
, 1,
SDPD, 1,
, 1,
, 1,
, 2,
SDRT, 1,
SDSC, 1,
@ -433,7 +444,14 @@ Method(FDDC, 2, Serialized)
/* todo Case(15) { STD0()} */ /* SATA */
Case(18) { U2D0()} /* EHCI */
Case(23) { U3D0()} /* XHCI */
/* todo Case(24) { SDD0()} */ /* SD */
Case(24) { /* SD */
Store(0x00, SDTD)
Store(One, SDPD)
Store(SDDS, Local0)
while(LNotEqual(Local0,0x7)) {
Store(SDDS, Local0)
}
}
}
} else {
/* put device into D3cold */
@ -489,7 +507,14 @@ Method(FDDC, 2, Serialized)
/* todo Case(15) { STD3()} */ /* SATA */
Case(18) { U2D3()} /* EHCI */
Case(23) { U3D3()} /* XHCI */
/* todo Case(24) { SDD3()} */ /* SD */
Case(24) { /* SD */
Store(Zero, SDPD)
Store(SDDS, Local0)
while(LNotEqual(Local0,0x0)) {
Store(SDDS, Local0)
}
Store(0x03, SDTD)
}
}
/* Turn off Power */
if(LEqual(I0TD, 3)) {