mb/hp/pavilion_m6_1035dx: Fix typos
Change-Id: Ibd6f6bf7983382901a5327121d277606f609eca4 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38365 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
parent
71a7ca786e
commit
291e88a01c
|
@ -92,15 +92,15 @@ static const CODEC_TBL_LIST CodecTableList[] =
|
||||||
#define FREQ_14HZ 0xFE
|
#define FREQ_14HZ 0xFE
|
||||||
#define FREQ_11HZ 0xFF
|
#define FREQ_11HZ 0xFF
|
||||||
|
|
||||||
/* Parmer Hardware Monitor Fan Control
|
/* Hardware Monitor Fan Control
|
||||||
* Hardware limitation:
|
* Hardware limitation:
|
||||||
* HWM failed to read the input temperture vi I2C,
|
* HWM failed to read the input temperature via I2C,
|
||||||
* if other software switch the I2C switch by mistake or intention.
|
* if other software switches the I2C switch by mistake or intention.
|
||||||
* We recommend to using IMC to control Fans, instead of HWM.
|
* We recommend using IMC to control Fans, instead of HWM.
|
||||||
*/
|
*/
|
||||||
static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
|
static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
|
||||||
{
|
{
|
||||||
/* Enable IMC fan control. the recommand way */
|
/* Enable IMC fan control, the recommended way */
|
||||||
if (CONFIG(HUDSON_IMC_FWM)) {
|
if (CONFIG(HUDSON_IMC_FWM)) {
|
||||||
imc_reg_init();
|
imc_reg_init();
|
||||||
|
|
||||||
|
@ -155,12 +155,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
|
||||||
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
|
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
|
||||||
|
|
||||||
/* NOTE:
|
/* NOTE:
|
||||||
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege,
|
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
|
||||||
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it.
|
* AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
|
||||||
* so we remove it from AGESA code. Please Seee FchInitLateHwm.
|
* So we remove it from AGESA code. Please See FchInitLateHwm.
|
||||||
*/
|
*/
|
||||||
} else {
|
} else {
|
||||||
/* HWM fan control, the way not recommand */
|
/* HWM fan control, the way not recommended */
|
||||||
FchParams->Imc.ImcEnable = FALSE;
|
FchParams->Imc.ImcEnable = FALSE;
|
||||||
FchParams->Hwm.HwMonitorEnable = TRUE;
|
FchParams->Hwm.HwMonitorEnable = TRUE;
|
||||||
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */
|
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */
|
||||||
|
|
Loading…
Reference in New Issue