GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/gm45/acpi: Fix max PCI bus number 

Commit 0cc56a2848 (nb/intel/gm45/dsdt: Fix number of PCI busses) derives
the maximum PCI bus number at runtime. However, IASL complains about the
initial 0 in the resource template, which rendered the PB00 definition
self-contradictory at build time (maximum was lower than minimum +
length - 1).

Let's return to the old default values (min: 0, max: 255, length: 256)
and adapt max and length at runtime. Also fix some surrounding whites-
pace.

NB. The issue wasn't detected before merging commit 0cc56a2848 because
of broken IASL versions that can't count errors.

Change-Id: I359d357f276feda8fe04383080d51dc492c3f2e8
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64347
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Stefan Ott <coreboot@desire.ch>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2022-05-14 15:57:31 +02:00 committed by Felix Held
parent ffd75c2936
commit 2a167ffbbf
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/northbridge/intel/gm45/acpi/hostbridge.asl
View File

@ -83,10 +83,9 @@ Device (MCHC)
Name (MCRS, ResourceTemplate() Name (MCRS, ResourceTemplate()
{ {
/* Bus Numbers. Highest bus gets updated later */ /* Bus Numbers. Highest bus and length get updated later */
WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
0x0000, 0x0000, 0x0000, 0x0000, 0, 0, 255, 0, 256,,, PB00)
CONFIG_ECAM_MMCONF_BUS_NUMBER,,, PB00)
/* IO Region 0 */ /* IO Region 0 */
DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
@ -208,9 +207,10 @@ External (A4GB, IntObj)
/* Current Resource Settings */ /* Current Resource Settings */
Method (_CRS, 0, Serialized) Method (_CRS, 0, Serialized)
{ {
/* Set highest PCI bus */ /* Set highest PCI bus and length */
CreateWordField(MCRS, ^PB00._MAX, BMAX) CreateWordField(MCRS, ^PB00._MAX, BMAX)
CreateWordField(MCRS, ^PB00._LEN, BLEN) CreateWordField(MCRS, ^PB00._LEN, BLEN)
BLEN = CONFIG_ECAM_MMCONF_BUS_NUMBER
BMAX = BLEN - 1 BMAX = BLEN - 1
/* Find PCI resource area in MCRS */ /* Find PCI resource area in MCRS */