soc/intel/broadwell: Move `mainboard_fill_spd_data`

Move the `mainboard_fill_spd_data` function out of romstage, in
preparation to confine `pei_data` usage to as few files as possible.

Change-Id: I6447da4d135d920f9145e817bfb7f9056e09df84
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55805
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2021-06-23 14:26:45 +02:00 committed by Felix Held
parent 887b779c11
commit 2bc7a6b3d2
7 changed files with 8 additions and 9 deletions

View File

@ -5,7 +5,7 @@
#include <mainboard/google/auron/variant.h>
#include <southbridge/intel/lynxpoint/lp_gpio.h>
#include <soc/pei_data.h>
#include <soc/romstage.h>
#include <soc/pei_wrapper.h>
#include <string.h>
#include <types.h>

View File

@ -2,6 +2,7 @@
#include <mainboard/google/auron/variant.h>
#include <soc/pei_data.h>
#include <soc/pei_wrapper.h>
/* Copy SPD data for on-board memory */
void mainboard_fill_spd_data(struct pei_data *pei_data)

View File

@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <soc/pei_data.h>
#include <soc/romstage.h>
#include <soc/pei_wrapper.h>
/* Copy SPD data for on-board memory */
void mainboard_fill_spd_data(struct pei_data *pei_data)

View File

@ -28,5 +28,6 @@ static inline void pei_data_usb3_port(struct pei_data *pei_data, int port,
void broadwell_fill_pei_data(struct pei_data *pei_data);
void mainboard_fill_pei_data(struct pei_data *pei_data);
void mainboard_fill_spd_data(struct pei_data *pei_data);
#endif

View File

@ -3,9 +3,6 @@
#ifndef _BROADWELL_ROMSTAGE_H_
#define _BROADWELL_ROMSTAGE_H_
#include <soc/pei_data.h>
void mainboard_fill_spd_data(struct pei_data *pei_data);
void mainboard_post_raminit(const int s3resume);
struct chipset_power_state;

View File

@ -177,6 +177,10 @@ static void setup_sdram_meminfo(struct pei_data *pei_data)
}
}
__weak void mainboard_fill_spd_data(struct pei_data *pei_data)
{
}
void perform_raminit(const struct chipset_power_state *const power_state)
{
const int s3resume = power_state->prev_sleep_state == ACPI_S3;

View File

@ -14,10 +14,6 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
#include <stdint.h>
__weak void mainboard_fill_spd_data(struct pei_data *pei_data)
{
}
__weak void mainboard_post_raminit(const int s3resume)
{
}