From 2c102232e8f74cff55e1ee75f785781ab27111dd Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 20 May 2022 18:26:18 +0200 Subject: [PATCH] mb/amd/chausie,google/skyrim: increase RW_MRC_CACHE size to 120 kByte The APOB data in DRAM is larger than the 96 kBytes of RW_MRC_CACHE, so it won't fit in the flash and makes soc_update_apob_cache return early before writing the APOB data from DRAM into the flash with this warning: [WARN ] RAM APOB data is too large 1db18 > 18000 Increasing the RW_MRC_CACHE size to 120 kByte fixes this. Signed-off-by: Felix Held Change-Id: I763d20f504d4f5b7cea68f21f409de9a1035f440 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64555 Reviewed-by: Raul Rangel Reviewed-by: Fred Reitberger Tested-by: build bot (Jenkins) --- src/mainboard/amd/chausie/board.fmd | 2 +- src/mainboard/amd/chausie/chromeos.fmd | 2 +- src/mainboard/google/skyrim/chromeos.fmd | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/amd/chausie/board.fmd b/src/mainboard/amd/chausie/board.fmd index ec87bbaddb..6c6ad92a28 100644 --- a/src/mainboard/amd/chausie/board.fmd +++ b/src/mainboard/amd/chausie/board.fmd @@ -1,7 +1,7 @@ FLASH@0xFF000000 16M { BIOS { EC 4K - RW_MRC_CACHE 96K + RW_MRC_CACHE 120K FMAP 4K COREBOOT(CBFS) } diff --git a/src/mainboard/amd/chausie/chromeos.fmd b/src/mainboard/amd/chausie/chromeos.fmd index 959a05ce9b..a27d5c34c0 100644 --- a/src/mainboard/amd/chausie/chromeos.fmd +++ b/src/mainboard/amd/chausie/chromeos.fmd @@ -1,7 +1,7 @@ FLASH@0xFF000000 16M { SI_BIOS { EC 4K - RW_MRC_CACHE(PRESERVE) 96K + RW_MRC_CACHE(PRESERVE) 120K RW_SECTION_A 4M { VBLOCK_A 8K FW_MAIN_A(CBFS) diff --git a/src/mainboard/google/skyrim/chromeos.fmd b/src/mainboard/google/skyrim/chromeos.fmd index c114c03309..3be90a44fe 100644 --- a/src/mainboard/google/skyrim/chromeos.fmd +++ b/src/mainboard/google/skyrim/chromeos.fmd @@ -1,6 +1,6 @@ FLASH@0xFF000000 16M { SI_BIOS { - RW_MRC_CACHE(PRESERVE) 96K + RW_MRC_CACHE(PRESERVE) 120K RW_SECTION_A 3M { VBLOCK_A 8K FW_MAIN_A(CBFS)