From 2c628f1652fb0ca28a1fc6c43225475362b50fc7 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Fri, 14 Jul 2017 15:42:35 -0600 Subject: [PATCH] soc/intel/skylake: remove top_of_32bit_ram() declaration It should never be globally exposed. Remove the global symbol and make it static. Change-Id: I3b85f3bbf6a73d480cdefdcdec26e137e3a3f75f Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/20584 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Subrata Banik --- src/soc/intel/skylake/include/soc/systemagent.h | 3 --- src/soc/intel/skylake/memmap.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/soc/intel/skylake/include/soc/systemagent.h b/src/soc/intel/skylake/include/soc/systemagent.h index 96e6c6a81b..d8192a3e75 100644 --- a/src/soc/intel/skylake/include/soc/systemagent.h +++ b/src/soc/intel/skylake/include/soc/systemagent.h @@ -42,7 +42,4 @@ #define MCH_DDR_POWER_LIMIT_LO 0x58e0 #define MCH_DDR_POWER_LIMIT_HI 0x58e4 -/* Top of 32bit usable memory */ -u32 top_of_32bit_ram(void); - #endif diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c index 17dbc320c6..43faabb011 100644 --- a/src/soc/intel/skylake/memmap.c +++ b/src/soc/intel/skylake/memmap.c @@ -137,7 +137,7 @@ int smm_subregion(int sub, void **start, size_t *size) * other words, the memory map is in a fixed order no matter what. */ -u32 top_of_32bit_ram(void) +static u32 top_of_32bit_ram(void) { msr_t prmrr_base; u32 top_of_ram;