GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb: Fix typos in comments in AGESA boards 

Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38609
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Lemenkov <lemenkov@gmail.com>
This commit is contained in:
Elyes HAOUAS 2020-01-28 18:11:14 +01:00 committed by Patrick Georgi
parent 38f7db79b5
commit 2cbfadd1de
7 changed files with 61 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/mainboard/amd/olivehill/BiosCallOuts.c
View File

@ -95,13 +95,13 @@ static const CODEC_TBL_LIST OlivehillCodecTableList[] =
/* Olivehill Hardware Monitor Fan Control /* Olivehill Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -156,12 +156,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

16
src/mainboard/amd/parmer/BiosCallOuts.c
View File

@ -95,13 +95,13 @@ static const CODEC_TBL_LIST CodecTableList[] =
/* Parmer Hardware Monitor Fan Control /* Parmer Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -156,12 +156,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

18
src/mainboard/amd/thatcher/BiosCallOuts.c
View File

@ -93,15 +93,15 @@ static const CODEC_TBL_LIST CodecTableList[] =
#define FREQ_14HZ 0xFE #define FREQ_14HZ 0xFE
#define FREQ_11HZ 0xFF #define FREQ_11HZ 0xFF
/* Parmer Hardware Monitor Fan Control /* Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -156,12 +156,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

18
src/mainboard/bap/ode_e20XX/BiosCallOuts.c
View File

@ -97,15 +97,15 @@ static const CODEC_TBL_LIST CodecTableList[] =
#define FREQ_14HZ 0xFE #define FREQ_14HZ 0xFE
#define FREQ_11HZ 0xFF #define FREQ_11HZ 0xFF
/* Hardware Monitor Fan Control /* Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -160,12 +160,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

18
src/mainboard/biostar/a68n_5200/BiosCallOuts.c
View File

@ -93,15 +93,15 @@ static const CODEC_TBL_LIST OlivehillCodecTableList[] =
#define FREQ_14HZ 0xFE #define FREQ_14HZ 0xFE
#define FREQ_11HZ 0xFF #define FREQ_11HZ 0xFF
/* Olivehill Hardware Monitor Fan Control /* Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -156,12 +156,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

18
src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c
View File

@ -93,15 +93,15 @@ static const CODEC_TBL_LIST CodecTableList[] =
#define FREQ_14HZ 0xFE #define FREQ_14HZ 0xFE
#define FREQ_11HZ 0xFF #define FREQ_11HZ 0xFF
/* Hardware Monitor Fan Control /* Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommand way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -156,12 +156,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please Seee FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommand */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */

18
src/mainboard/lenovo/g505s/BiosCallOuts.c
View File

@ -92,15 +92,15 @@ static const CODEC_TBL_LIST CodecTableList[] =
#define FREQ_14HZ 0xFE #define FREQ_14HZ 0xFE
#define FREQ_11HZ 0xFF #define FREQ_11HZ 0xFF
/* Parmer Hardware Monitor Fan Control /* Hardware Monitor Fan Control
* Hardware limitation: * Hardware limitation:
* HWM failed to read the input temperture vi I2C, * HWM failed to read the input temperature via I2C,
* if other software switch the I2C switch by mistake or intention. * if other software switches the I2C switch by mistake or intention.
* We recommend to using IMC to control Fans, instead of HWM. * We recommend using IMC to control Fans, instead of HWM.
*/ */
static void oem_fan_control(FCH_DATA_BLOCK *FchParams) static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
{ {
/* Enable IMC fan control. the recommend way */ /* Enable IMC fan control, the recommended way */
if (CONFIG(HUDSON_IMC_FWM)) { if (CONFIG(HUDSON_IMC_FWM)) {
imc_reg_init(); imc_reg_init();
@ -155,12 +155,12 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8; FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: /* NOTE:
* FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage,
* AGESA put EcDefaultMassege as global data in ROM, so we can't overwrite it. * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it.
* so we remove it from AGESA code. Please See FchInitLateHwm. * So we remove it from AGESA code. Please See FchInitLateHwm.
*/ */
} else { } else {
/* HWM fan control, the way not recommend */ /* HWM fan control, the way not recommended */
FchParams->Imc.ImcEnable = FALSE; FchParams->Imc.ImcEnable = FALSE;
FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwMonitorEnable = TRUE;
FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */