GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy: add the smi_events back 

Before entering the OS, the AP relies on the smi handler to shutdown the
system when the lid closes. Without the smi_events setting, the AP will
not receive the smi handler. As a result, the AP won't shutdown and will
always keep in S0.
This problem is caused by the https://review.coreboot.org/c/coreboot/+/28983
and this patch adds the smi_events back to support the smi handler for
the lid close.

BRANCH=master
BUG=b:115572596
TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown

Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-on: https://review.coreboot.org/29191
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
This commit is contained in:
Zhuohao Lee 2018-10-19 16:50:02 +08:00 committed by Furquan Shaikh
parent a342f3937e
commit 2ce56f1523
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/poppy/ec.c
View File

@ -24,6 +24,7 @@ __weak const struct google_chromeec_event_info *variant_get_event_info(void)
static const struct google_chromeec_event_info info = { static const struct google_chromeec_event_info info = {
.log_events = MAINBOARD_EC_LOG_EVENTS, .log_events = MAINBOARD_EC_LOG_EVENTS,
.sci_events = MAINBOARD_EC_SCI_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS,
.smi_events = MAINBOARD_EC_SMI_EVENTS,
.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
.s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS, .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,

1
src/mainboard/google/poppy/variants/nocturne/ec.c
View File

@ -25,6 +25,7 @@ const struct google_chromeec_event_info *variant_get_event_info(void)
static struct google_chromeec_event_info info = { static struct google_chromeec_event_info info = {
.log_events = MAINBOARD_EC_LOG_EVENTS, .log_events = MAINBOARD_EC_LOG_EVENTS,
.sci_events = MAINBOARD_EC_SCI_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS,
.smi_events = MAINBOARD_EC_SMI_EVENTS,
.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
.s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS, .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,