GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/fizz: Remove IccMax settings from DT 

This patch removes IccMax settings from device tree since they
are handled in SoC code from patch e1a75d.

BUG=b:71369428
BRANCH=None
TEST="USE=fw_debug emerge-fizz chromeos-mrc coreboot
     chromeos-bootimage" & ensure the IccMax settings passed
     to FSP are from SoC code.

Change-Id: I6b01c50a2589d1722c5bf4aa2f44a9574df818f4
Signed-off-by: Gaggery Tsai <gaggery.tsai@intel.com>
Reviewed-on: https://review.coreboot.org/23278
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shelley Chen <shchen@google.com>
This commit is contained in:
Gaggery Tsai 2018-01-15 22:48:18 +08:00 committed by Shelley Chen
parent 30a6b74f99
commit 2ce90903b0
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/fizz/devicetree.cb
View File

@ -117,6 +117,7 @@ chip soc/intel/skylake
#| IccMax | 7A | 34A | 35A | 35A | #| IccMax | 7A | 34A | 35A | 35A |
#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
#+----------------+-------+-------+-------+-------+ #+----------------+-------+-------+-------+-------+
#Note: IccMax settings are moved to SoC code
register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
.vr_config_enable = 1, .vr_config_enable = 1,
.psi1threshold = VR_CFG_AMP(20), .psi1threshold = VR_CFG_AMP(20),
@ -126,7 +127,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(7),
.voltage_limit = 1520, .voltage_limit = 1520,
}" }"
@ -139,7 +139,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(34),
.voltage_limit = 1520, .voltage_limit = 1520,
}" }"
@ -152,7 +151,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(35),
.voltage_limit = 1520, .voltage_limit = 1520,
}" }"
@ -165,7 +163,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(35),
.voltage_limit = 1520, .voltage_limit = 1520,
}" }"