GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

utils/romcc.c: Fix spurious unsigned integer comparisons. 

Clang warns about comparisons of unsigned integers with being below
zero. Remove spurious logic checks that are always false.

Change-Id: I70c4d5331df81e48bf7ef27ff98400c4218f7edc
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5275
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-02-20 20:06:42 +11:00 committed by Kyösti Mälkki
parent 946923b0fb
commit 2cf9715c9a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
util/romcc/romcc.c
View File

@ -2870,7 +2870,7 @@ static struct triple *do_farg(struct compile_state *state,
unsigned i; unsigned i;
ftype = func->type; ftype = func->type;
if((index < 0) || (index >= (ftype->elements + 2))) { if(index >= (ftype->elements + 2)) {
internal_error(state, func, "bad argument index: %d", index); internal_error(state, func, "bad argument index: %d", index);
} }
first = RHS(func, 0); first = RHS(func, 0);
@ -18328,7 +18328,7 @@ static void print_interference_block(
} }
/* Do a bunch of sanity checks */ /* Do a bunch of sanity checks */
valid_ins(state, ptr); valid_ins(state, ptr);
if ((ptr->id < 0) || (ptr->id > rstate->defs)) { if (ptr->id > rstate->defs) {
internal_error(state, ptr, "Invalid triple id: %d", internal_error(state, ptr, "Invalid triple id: %d",
ptr->id); ptr->id);
} }
@ -18943,7 +18943,7 @@ static void graph_ins(
*/ */
for(entry = live; entry; entry = entry->next) { for(entry = live; entry; entry = entry->next) {
struct live_range *lr; struct live_range *lr;
if ((entry->member->id < 0) || (entry->member->id > rstate->defs)) { if (entry->member->id > rstate->defs) {
internal_error(state, 0, "bad entry?"); internal_error(state, 0, "bad entry?");
} }
lr = rstate->lrd[entry->member->id].lr; lr = rstate->lrd[entry->member->id].lr;
@ -19915,7 +19915,7 @@ static void verify_colors(struct compile_state *state, struct reg_state *rstate)
ins = first; ins = first;
do { do {
if (triple_is_def(state, ins)) { if (triple_is_def(state, ins)) {
if ((ins->id < 0) || (ins->id > rstate->defs)) { if (ins->id > rstate->defs) {
internal_error(state, ins, internal_error(state, ins,
"triple without a live range def"); "triple without a live range def");
} }
@ -19950,7 +19950,7 @@ static void color_triples(struct compile_state *state, struct reg_state *rstate)
first = state->first; first = state->first;
ins = first; ins = first;
do { do {
if ((ins->id < 0) || (ins->id > rstate->defs)) { if (ins->id > rstate->defs) {
internal_error(state, ins, internal_error(state, ins,
"triple without a live range"); "triple without a live range");
} }